Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Dec 6, 2024

Change Summary

Part of pydantic/pydantic#11033

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #1572 will not alter performance

Comparing js-input-type-in-cs (9388249) with main (6a455fb)

Summary

✅ 155 untouched benchmarks

@Viicos Viicos force-pushed the js-input-type-in-cs branch from e4978a7 to 9388249 Compare December 10, 2024 20:56
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, nice.

Can we include this in v2.10.4?

@Viicos Viicos marked this pull request as ready for review December 12, 2024 14:11
@Viicos Viicos merged commit 98bc1e2 into main Dec 12, 2024
29 checks passed
@Viicos Viicos deleted the js-input-type-in-cs branch December 12, 2024 14:11
@Viicos Viicos added the backport-2.27 Needs backport to 2.27 label Dec 16, 2024
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-2.27 Needs backport to 2.27

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants