diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 01176881b..7ba7247a2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -362,8 +362,7 @@ jobs: # https://github.com/marketplace/actions/alls-green#why used for branch protection checks check: if: always() - # TODO: add build-wasm-emscripten back when CI installation failures are solved: - needs: [coverage, test-python, test-os, test-debug, lint, bench] + needs: [coverage, test-python, test-os, test-debug, lint, bench, build-wasm-emscripten] runs-on: ubuntu-latest steps: - name: Decide whether the needed jobs succeeded or failed diff --git a/tests/emscripten_runner.js b/tests/emscripten_runner.js index a49c1b6ad..ab1583da3 100644 --- a/tests/emscripten_runner.js +++ b/tests/emscripten_runner.js @@ -98,7 +98,8 @@ import importlib await micropip.install([ 'dirty-equals', - 'inline-snapshot', + # inline-snapshot 0.21 requires pytest 8.3.4, pyodide 0.26 ships with 8.1.1 + 'inline-snapshot < 0.21', 'hypothesis', 'pytest-speed', 'pytest-mock',