Match return type of SerializationInfo.mode() to mode of model_dump() #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pydantic sometimes uses Literal['python', 'json'] | str for the serialization mode. Using a more restrictive type can cause issues (e.g., typing validation errors). This commit adjusts the return type to align with other valid Pydantic serialization modes and prevent such issues. This can be seen as a follow-up to commit: 9b239c1
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
l00ptr
force-pushed
the
fix-return-type-for-mode
branch
from
a87f8c5 to
075cbcf
Compare
CodSpeed Performance ReportMerging #1770 will not alter performanceComparing Summary
|
davidhewitt
approved these changes
Sep 24, 2025
|
Should have marked the PR as blocked as I was waiting for an answer in #1747 (comment). I'll revert and change other places where |
Viicos
added a commit
that referenced
this pull request
Sep 29, 2025
…l_dump() (#1770)" This reverts commit d0dbb09. See #1747 (comment) for more details.
Viicos
added a commit
that referenced
this pull request
Sep 29, 2025
Viicos
added a commit
that referenced
this pull request
Oct 1, 2025
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…pydantic/pydantic-core#1770) Co-authored-by: Julian Vanden Broeck <[email protected]> Original-commit-hash: d0dbb09
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…l_dump() (pydantic/pydantic-core#1770)" (pydantic/pydantic-core#1797) Original-commit-hash: 25b0649
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…el_dump() (pydantic/pydantic-core#1770)" (pydantic/pydantic-core#1797) (pydantic/pydantic-core#1815) Original-commit-hash: 7a1a124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Pydantic in some place use
Literal['python', 'json'] | strfor the serialization mode, using a more restrictive type can break stuff (e.g. typing validation). So this commit adapt the return type to make it matches with other pydantic valid serialization mode.Related issue number
Checklist
pydantic-core(except for expected changes)