Add support for pymongo bson ObjectId #290
Merged
+246
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezz123
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
LGTM 🚀 One thing is missing is adding test here https://github.com/pydantic/pydantic-extra-types/blob/main/tests/test_json_schema.py
and we are ready to merge
yezz123
changed the title
13 tasks
I will add the test for the json schema tomorrow and the |
|
Hi @yezz123, just added some more testing, I think it's ready to merge now. |
|
Hello @yezz123, any timeline when a release from this would be made? Would love to start using this in my projects. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #133
Moved from: #151