♻️ raise ValueError instead of AttributeError on wrong S3Path value
#354
+21
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey here!
Thank you for the library!
Motivation
I'm using
pydantic-extra-typesas an optional dependency in my small library I will release soon.I decided to test all types from
pydanic-extra-typesto verify that validation is successful.But for
S3Paththe error wasAttributeErrorinstead ofValueError, that I (or any otherpydanticuser IMHO) would expect.Changes
Refactor of
S3Pathinit to raiseValueErrorand notAttributeErrorand tests that verify that on init (without usingpydanticfeatures)ValueErroris raised. I also changedpattfromstrtoPatternfor optimization