Skip to content

Conversation

@Danipulok
Copy link
Contributor

Hey here!
Thank you for the library!

Motivation

I'm using pydantic-extra-types as an optional dependency in my small library I will release soon.
I decided to test all types from pydanic-extra-types to verify that validation is successful.
But for S3Path the error was AttributeError instead of ValueError, that I (or any other pydantic user IMHO) would expect.

Changes

Refactor of S3Path init to raise ValueError and not AttributeError and tests that verify that on init (without using pydantic features) ValueError is raised. I also changed patt from str to Pattern for optimization

@yezz123 yezz123 merged commit 6a5ffac into pydantic:main Nov 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants