simple if/else

Author: pmeier

pydantic_settings/sources/base.py

@@ -198,17 +198,16 @@ def _read_files(self, files: PathType | None, deep_merge: bool = False) -> dict[
         if isinstance(files, (str, os.PathLike)):
             files = [files]
         vars: dict[str, Any] = {}
-        update = deep_update if deep_merge else self._shallow_update
         for file in files:
             file_path = Path(file).expanduser()
-            if file_path.is_file():
-                vars = update(vars, self._read_file(file_path))
-        return vars
+            if not file_path.is_file():
+                continue
 
-    def _shallow_update(self, vars: dict[str, Any], updating_vars: dict[str, Any]) -> dict[str, Any]:
-        # this mimics the semantics of pydantic._internal._utils.deep_update
-        vars = vars.copy()
-        vars.update(updating_vars)
+            updating_vars = self._read_file(file_path)
+            if deep_merge:
+                vars = deep_update(vars, updating_vars)
+            else:
+                vars.update(updating_vars)
         return vars
 
     @abstractmethod