Skip to content

Commit 275e6da

Browse files
committed
Depend on the warning order in test
1 parent 73c5190 commit 275e6da

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

tests/test_settings.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3148,7 +3148,6 @@ class Settings(BaseSettings):
31483148
Settings()
31493149

31503150
assert len(record) == 5
3151-
assert all(warning.category is UserWarning for warning in record)
31523151

31533152
key_class_pairs = [
31543153
('json_file', 'JsonConfigSettingsSource'),
@@ -3158,14 +3157,11 @@ class Settings(BaseSettings):
31583157
('yaml_config_section', 'YamlConfigSettingsSource'),
31593158
]
31603159

3161-
for key_class_pair in key_class_pairs:
3160+
for warning, key_class_pair in zip(record, key_class_pairs):
3161+
assert warning.category is UserWarning
31623162
expected_message = (
31633163
f'Config key `{key_class_pair[0]}` is set in model_config but will be ignored because no '
31643164
f'{key_class_pair[1]} source is configured. To use this config key, add a {key_class_pair[1]} '
31653165
f'source to the settings sources via the settings_customise_sources hook.'
31663166
)
3167-
3168-
warning_count = sum(warning.message.args[0] == expected_message for warning in record)
3169-
assert warning_count == 1, (
3170-
f'Expected exactly one warning with message "{expected_message}", but found {warning_count} instead.'
3171-
)
3167+
assert warning.message.args[0] == expected_message

0 commit comments

Comments
 (0)