Add test for exception.

Author: kschwab

pydantic_settings/sources/providers/cli.py

@@ -669,7 +669,7 @@ def _parse_known_args(*args: Any, **kwargs: Any) -> Namespace:
         self._cli_dict_args: dict[str, type[Any] | None] = {}
         self._cli_subcommands: defaultdict[str, dict[str, str]] = defaultdict(dict)
         self._is_serialize_args = isinstance(root_parser, _CliInternalArgSerializer)
-        self._serialized_positional_args: dict[str, Any] = {}
+        self._serialize_positional_args: dict[str, Any] = {}
         self._add_parser_args(
             parser=self.root_parser,
             model=self.settings_cls,
@@ -871,7 +871,7 @@ def _convert_positional_arg(
             kwargs['nargs'] = '?'
 
         if self._is_serialize_args:
-            self._serialized_positional_args[kwargs['dest']] = kwargs['default']
+            self._serialize_positional_args[kwargs['dest']] = kwargs['default']
             kwargs['nargs'] = '*'
 
         kwargs['default'] = PydanticUndefined
@@ -1131,11 +1131,9 @@ def _update_alias_path_only_defaults(
         if not alias_nested_paths:
             alias_path_only_defaults.setdefault(dest, [])
             alias_default = alias_path_only_defaults[dest]
-            assert isinstance(alias_default, list)
         else:
             alias_path_only_defaults.setdefault(dest, {})
             current_path = alias_path_only_defaults[dest]
-            assert isinstance(current_path, dict)
 
             for nested_path in alias_nested_paths[:-1]:
                 current_path.setdefault(nested_path, {})
@@ -1148,16 +1146,17 @@ def _update_alias_path_only_defaults(
         alias_default[alias_path_index] = default
 
     def _serialized_args(self) -> list[str]:
-        assert self._is_serialize_args
+        if not self._is_serialize_args:
+            raise SettingsError('Root parser is not _CliInternalArgSerializer')
 
         cli_args = []
-        for arg, values in self._serialized_positional_args.items():
+        for arg, values in self._serialize_positional_args.items():
             for value in values if isinstance(values, list) else [values]:
                 value = json.dumps(value) if isinstance(value, (dict, list, set)) else str(value)
                 cli_args.append(value)
 
         for arg, value in self.env_vars.items():
-            if arg not in self._serialized_positional_args:
+            if arg not in self._serialize_positional_args:
                 value = json.dumps(value) if isinstance(value, (dict, list, set)) else str(value)
                 cli_args.append(f'{self.cli_flag_prefix_char * min(len(arg), 2)}{arg}')
                 cli_args.append(value)

tests/test_source_cli.py

@@ -1974,6 +1974,9 @@ class Cfg(BaseSettings):
     with pytest.raises(SettingsError, match='CLI settings source prefix is invalid: 123'):
         CliSettingsSource(Cfg, cli_prefix='123')
 
+    with pytest.raises(SettingsError, match='Root parser is not _CliInternalArgSerializer'):
+        CliSettingsSource[Any](Cfg, cli_parse_args=[])._serialized_args()
+
     class Food(BaseModel):
         fruit: FruitsEnum = FruitsEnum.kiwi