Skip to content

CLI support for optional and variadic positional args #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2025
Merged

CLI support for optional and variadic positional args #519

merged 5 commits into from
Jan 13, 2025

Conversation

@kschwab
Copy link
Contributor

@kschwab kschwab commented Jan 10, 2025 •
edited
Loading

Fixes #517
Fixes #518

hyperlint-ai[bot]
hyperlint-ai bot reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Ss]ubcommands

@kschwab kschwab mentioned this pull request Jan 10, 2025
Closed
@kschwab kschwab marked this pull request as draft January 11, 2025 14:40
hyperlint-ai[bot]
hyperlint-ai bot reviewed Jan 11, 2025
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Ss]ubcommands?

@kschwab kschwab changed the title Cli support optional positional args CLI support for optional and variadic positional args Jan 11, 2025
@kschwab kschwab marked this pull request as ready for review January 11, 2025 15:25
@kschwab kschwab mentioned this pull request Jan 11, 2025
Closed
@hramezani hramezani merged commit e2cbb2d into pydantic:main Jan 13, 2025
23 checks passed
@hramezani
Copy link
Member

hramezani commented Jan 13, 2025

Thanks @kschwab

@jploskey jploskey mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani approved these changes

+1 more reviewer

@hyperlint-ai hyperlint-ai[bot] hyperlint-ai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support variadic positional args when parsing from CLI Support default values for CliPositionalArg when parsing from the CLI

2 participants

@kschwab @hramezani