Skip to content

Commit 08a700e

Browse files
author
David Stephens
committed
BUG: Skip tests for google quotes
Add note to docs re: status of google quotes rebase
1 parent 7d8803d commit 08a700e

File tree

3 files changed

+21
-9
lines changed

3 files changed

+21
-9
lines changed

docs/source/remote_data.rst

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,13 @@ Google Finance Quotes
170170

171171
The GoogleQuotesReader class allows to get quotes data from Google Finance.
172172

173-
.. ipython:: python
173+
OFFLINE AS OF OCT 1, 2017
174174

175-
import pandas_datareader.data as web
176-
q = web.get_quote_google(['AMZN', 'GOOG'])
177-
q
175+
.. .. ipython:: python
176+
177+
.. import pandas_datareader.data as web
178+
.. q = web.get_quote_google(['AMZN', 'GOOG'])
179+
.. q
178180
179181
.. _remote_data.google_options:
180182

pandas_datareader/google/quotes.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99

1010
class GoogleQuotesReader(_BaseReader):
1111

12-
"""Get current google quote"""
12+
"""Get current google quote
13+
WARNING: OFFLINE AS OF OCT 1, 2017
14+
"""
1315

1416
@property
1517
def url(self):

pandas_datareader/tests/google/test_google.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def test_google(self):
6161

6262
for locale in self.locales:
6363
with tm.set_locale(locale):
64-
panel = web.DataReader("F", 'google', start, end)
64+
panel = web.DataReader("NYSE:F", 'google', start, end)
6565
assert panel.Close[-1] == 13.68
6666

6767
with pytest.raises(Exception):
@@ -82,12 +82,14 @@ def assert_option_result(self, df):
8282
tm.assert_series_equal(df.dtypes, pd.Series(dtypes, index=exp_columns))
8383

8484
def test_get_quote_string(self):
85+
pytest.skip("Google quote api is offline as of Oct 1, 2017")
8586
df = web.get_quote_google('GOOG')
8687
assert df.loc['GOOG', 'last'] > 0.0
8788
tm.assert_index_equal(df.index, pd.Index(['GOOG']))
8889
self.assert_option_result(df)
8990

9091
def test_get_quote_stringlist(self):
92+
pytest.skip("Google quote api is offline as of Oct 1, 2017")
9193
df = web.get_quote_google(['GOOG', 'AMZN', 'GOOG'])
9294
assert_series_equal(df.iloc[0], df.iloc[2])
9395
tm.assert_index_equal(df.index, pd.Index(['GOOG', 'AMZN', 'GOOG']))
@@ -143,7 +145,10 @@ def test_get_multi2(self):
143145

144146
def test_dtypes(self):
145147
# see gh-3995, gh-8980
146-
data = web.get_data_google('F', start='JAN-01-10', end='JAN-27-13')
148+
data = web.get_data_google(
149+
'NYSE:F',
150+
start='JAN-01-10',
151+
end='JAN-27-13')
147152
assert np.issubdtype(data.Open.dtype, np.number)
148153
assert np.issubdtype(data.Close.dtype, np.number)
149154
assert np.issubdtype(data.Low.dtype, np.number)
@@ -152,7 +157,10 @@ def test_dtypes(self):
152157

153158
def test_unicode_date(self):
154159
# see gh-8967
155-
data = web.get_data_google('F', start='JAN-01-10', end='JAN-27-13')
160+
data = web.get_data_google(
161+
'NYSE:F',
162+
start='JAN-01-10',
163+
end='JAN-27-13')
156164
assert data.index.name == 'Date'
157165

158166
def test_google_reader_class(self):
@@ -167,4 +175,4 @@ def test_google_reader_class(self):
167175
def test_bad_retry_count(self):
168176

169177
with pytest.raises(ValueError):
170-
web.get_data_google('F', retry_count=-1)
178+
web.get_data_google('NYSE:F', retry_count=-1)

0 commit comments

Comments
 (0)