Skip to content

Commit 6dea000

Browse files
CLN: Add NotImplementedError to DataReader
If requested data source hasn't been implemented.
1 parent 5422d79 commit 6dea000

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

pandas_datareader/data.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@ def DataReader(name, data_source=None, start=None, end=None,
9090
return get_data_fred(name, start, end)
9191
elif data_source == "famafrench":
9292
return get_data_famafrench(name)
93-
93+
else:
94+
raise NotImplementedError(
95+
"data_source=%r is not implemented" % data_source)
9496

9597
def _sanitize_dates(start, end):
9698
from pandas.core.datetools import to_datetime

pandas_datareader/tests/test_data.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -471,6 +471,9 @@ def test_read_famafrench(self):
471471
assert ff
472472
assert isinstance(ff, dict)
473473

474+
def test_not_implemented(self):
475+
self.assertRaises(NotImplementedError, DataReader, "NA", "NA")
476+
474477

475478
class TestFred(tm.TestCase):
476479
def test_fred(self):

0 commit comments

Comments
 (0)