Skip to content

Commit 747a67b

Browse files
authored
Merge pull request #463 from bashtage/new-google-urls
New google urls
2 parents dcc09eb + 833d6a3 commit 747a67b

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

pandas_datareader/google/daily.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def __init__(self, symbols=None, start=None, end=None, retry_count=3,
4444

4545
@property
4646
def url(self):
47-
return 'http://finance.google.com/finance/historical'
47+
return 'https://finance.google.com/finance/historical'
4848

4949
def _get_params(self, symbol):
5050
params = {

pandas_datareader/google/quotes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class GoogleQuotesReader(_BaseReader):
1515

1616
@property
1717
def url(self):
18-
return 'http://www.google.com/finance/info'
18+
return 'https://finance.google.com/finance/info'
1919

2020
@property
2121
def params(self):

pandas_datareader/tests/test_iex.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,7 @@ def test_live_prices(self):
4545

4646
def test_deep(self):
4747
dob = get_iex_book('GS', service='book')
48-
assert 'GS' in dob
48+
if dob:
49+
assert 'GS' in dob
50+
else:
51+
pytest.xfail(reason='Can only get Book when market open')

0 commit comments

Comments
 (0)