Merge branch 'master' into master

Author: bashtage

docs/source/readers/enigma.rst

@@ -1,4 +1,4 @@
-Engima
+Enigma
 ------
 
 .. py:module:: pandas_datareader.enigma

docs/source/readers/index.rst

@@ -17,7 +17,6 @@ Data Readers
    nasdaq-trader
    oecd
    quandl
-   robinhood
    stooq
    tiingo
    tsp

docs/source/remote_data.rst

@@ -21,6 +21,11 @@ Remote Data Access
 
   Yahoo! Finance, Google Finance, and Morningstar have been immediately deprecated.  Endpoints from these providers have been retired
 
+.. warning::
+
+    Robinhood has been immediately deprecated. Endpoints from this provider
+    have been retired.
+
 .. _remote_data.data_reader:
 
 Functions from :mod:`pandas_datareader.data` and :mod:`pandas_datareader.wb`
@@ -29,7 +34,6 @@ Currently the following sources are supported:
 
     - :ref:`Tiingo<remote_data.tiingo>`
     - :ref:`IEX<remote_data.iex>`
-    - :ref:`Robinhood<remote_data.robinhood>`
     - :ref:`Alpha Vantage<remote_data.alphavantage>`
     - :ref:`Enigma<remote_data.enigma>`
     - :ref:`Quandl<remote_data.quandl>`
@@ -94,21 +98,6 @@ A third interface to the deep API is exposed through
     f[:10]
 
 
-.. _remote_data.robinhood:
-
-Robinhood
-=========
-`Robinhood <https://www.robinhood.com>`__ is a stock trading platform with an
-API that provides a limited set of data. Historical daily data is limited to 1
-year relative to today.
-
-.. ipython:: python
-
-    import pandas_datareader.data as web
-    from datetime import datetime
-    f = web.DataReader('F', 'robinhood')
-    f.head()
-
 .. _remote_data.alphavantage:
 
 Alpha Vantage

docs/source/whatsnew/v0.8.0.txt

@@ -8,6 +8,9 @@ Highlights include:
 - A new connector for Econdb was introduced.  Econdb provides
   aggregated economic data from 90+ official statistical agencies
   (:issue:`615`)
+- Immediate deprecation of Robinhood for quotes and historical data. Robinhood
+  ended support for these endpoints in 1/2019
+
 
 .. contents:: What's new in v0.8.0
     :local:
@@ -24,6 +27,9 @@ Enhancements
 Backwards incompatible API changes
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
+- Immediate deprecation of Robinhood for quotes and historical data. Robinhood
+  ended support for these endpoints in 1/2019. The Robinhood quotes and daily
+  readers will raise an ``ImmediateDeprecationError`` when called.
 
 
 .. _whatsnew_080.bug_fixes:

pandas_datareader/av/__init__.py

@@ -28,7 +28,7 @@ def __init__(self, symbols=None, start=None, end=None, retry_count=3,
         if not api_key or not isinstance(api_key, str):
             raise ValueError('The AlphaVantage API key must be provided '
                              'either through the api_key variable or '
-                             'through the environment varaible '
+                             'through the environment variable '
                              'ALPHAVANTAGE_API_KEY')
         self.api_key = api_key
 

pandas_datareader/robinhood.py

@@ -1,12 +1,17 @@
 import pandas as pd
 
 from pandas_datareader.base import _BaseReader
+from pandas_datareader.exceptions import (ImmediateDeprecationError,
+                                          DEP_ERROR_MSG)
 
 
 class RobinhoodQuoteReader(_BaseReader):
     """
     Read quotes from Robinhood
 
+    DEPRECATED 1/2019 - Robinhood ended support for the endpoints used by this
+    reader
+
     Parameters
     ----------
     symbols : {str, List[str]}
@@ -28,6 +33,7 @@ class RobinhoodQuoteReader(_BaseReader):
 
     def __init__(self, symbols, start=None, end=None, retry_count=3, pause=.1,
                  timeout=30, session=None, freq=None):
+        raise ImmediateDeprecationError(DEP_ERROR_MSG.format("Robinhood"))
         super(RobinhoodQuoteReader, self).__init__(symbols, start, end,
                                                    retry_count, pause,
                                                    timeout, session, freq)
@@ -72,6 +78,9 @@ class RobinhoodHistoricalReader(RobinhoodQuoteReader):
     """
     Read historical values from Robinhood
 
+    DEPRECATED 1/2019 - Robinhood ended support for the endpoints used by this
+    reader
+
     Parameters
     ----------
     symbols : {str, List[str]}
@@ -110,6 +119,7 @@ class RobinhoodHistoricalReader(RobinhoodQuoteReader):
     def __init__(self, symbols, start=None, end=None, retry_count=3, pause=.1,
                  timeout=30, session=None, freq=None, interval='day',
                  span='year'):
+        raise ImmediateDeprecationError(DEP_ERROR_MSG.format("Robinhood"))
         super(RobinhoodHistoricalReader, self).__init__(symbols, start, end,
                                                         retry_count, pause,
                                                         timeout, session, freq)

pandas_datareader/tests/test_robinhood.py

@@ -14,6 +14,7 @@ def symbols(request):
     return request.param
 
 
+@pytest.mark.xfail(reason="Deprecated")
 def test_robinhood_quote(symbols):
     df = RobinhoodQuoteReader(symbols=symbols).read()
     assert isinstance(df, pd.DataFrame)
@@ -22,6 +23,7 @@ def test_robinhood_quote(symbols):
     assert df.shape[1] == len(symbols)
 
 
+@pytest.mark.xfail(reason="Deprecated")
 def test_robinhood_quote_too_many():
     syms = np.random.randint(65, 90, size=(10000, 4)).tolist()
     syms = list(map(lambda r: ''.join(map(chr, r)), syms))
@@ -30,6 +32,7 @@ def test_robinhood_quote_too_many():
         RobinhoodQuoteReader(symbols=syms)
 
 
+@pytest.mark.xfail(reason="Deprecated")
 def test_robinhood_historical_too_many():
     syms = np.random.randint(65, 90, size=(10000, 4)).tolist()
     syms = list(map(lambda r: ''.join(map(chr, r)), syms))
@@ -40,6 +43,7 @@ def test_robinhood_historical_too_many():
         RobinhoodHistoricalReader(symbols=syms[:76])
 
 
+@pytest.mark.xfail(reason="Deprecated")
 def test_robinhood_historical(symbols):
     df = RobinhoodHistoricalReader(symbols=symbols).read()
     assert isinstance(df, pd.DataFrame)

pandas_datareader/yahoo/actions.py

@@ -33,14 +33,16 @@ def _get_one_action(data):
         dividends = DataFrame(data['Dividends']).dropna()
         dividends["action"] = "DIVIDEND"
         dividends = dividends.rename(columns={'Dividends': 'value'})
-        actions = concat([actions, dividends]).sort_index(ascending=False)
+        actions = concat([actions, dividends], sort=True)
+        actions = actions.sort_index(ascending=False)
 
     if 'Splits' in data.columns:
         # Add a label column so we can combine our two DFs
         splits = DataFrame(data['Splits']).dropna()
         splits["action"] = "SPLIT"
         splits = splits.rename(columns={'Splits': 'value'})
-        actions = concat([actions, splits]).sort_index(ascending=False)
+        actions = concat([actions, splits], sort=True)
+        actions = actions.sort_index(ascending=False)
 
     return actions