MAINT: Remove nose dependency (#312)

Author: gfyoung

.travis.yml

@@ -30,12 +30,9 @@ install:
   - conda update -q conda
   # Useful for debugging any issues with conda
   - conda info -a
-  - conda create -q -n test-environment python=$PYTHON pandas=$PANDAS nose coverage setuptools html5lib lxml pytest pytest-cov
+  - conda create -q -n test-environment python=$PYTHON pandas=$PANDAS coverage setuptools html5lib lxml pytest pytest-cov
   - source activate test-environment
   - pip install beautifulsoup4
-  - if [[ "$PYTHON" == "2.6" ]]; then
-      pip install simplejson;
-    fi
   - pip install coveralls --quiet
   - conda list
   - python setup.py install

pandas_datareader/tests/_utils.py

@@ -1,4 +1,3 @@
-import nose
 import pandas.util.testing as tm
 import pandas_datareader.base as base
 
@@ -26,8 +25,3 @@ def test_get_params(self):
         with tm.assertRaises(NotImplementedError):
             b = base._DailyBaseReader()
             b._get_params()
-
-
-if __name__ == '__main__':
-    nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],
-                   exit=False)

pandas_datareader/tests/test_base.py

@@ -1,14 +1,7 @@
-import nose
-
-from pandas import DataFrame
-try:
-    from pandas.util.testing import assert_produces_warning
-except ImportError:  # pragma: no cover
-    assert_produces_warning = None
-
 import pandas.util.testing as tm
-
 import pandas_datareader.data as web
+
+from pandas import DataFrame
 from pandas_datareader.data import DataReader
 
 
@@ -22,11 +15,8 @@ def tearDownClass(cls):
         super(TestOptionsWarnings, cls).tearDownClass()
 
     def test_options_source_warning(self):
-        if not assert_produces_warning:  # pragma: no cover
-            raise nose.SkipTest("old version of pandas without "
-                                "compat.assert_produces_warning")
-        with assert_produces_warning():
-            aapl = web.Options('aapl')  # noqa
+        with tm.assert_produces_warning():
+            web.Options('aapl')
 
 
 class TestDataReader(tm.TestCase):
@@ -52,8 +42,3 @@ def test_read_fred(self):
 
     def test_not_implemented(self):
         self.assertRaises(NotImplementedError, DataReader, "NA", "NA")
-
-
-if __name__ == '__main__':
-    nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],
-                   exit=False)  # pragma: no cover

pandas_datareader/tests/test_data.py

@@ -1,17 +1,21 @@
-import nose
+import pytest
 
 import pandas as pd
 import pandas.util.testing as tm
-
 import pandas_datareader.data as web
+
 from pandas_datareader._utils import RemoteDataError
 
 
 class TestEdgarIndex(tm.TestCase):
 
+    @classmethod
+    def setup_class(cls):
+        # As of December 31, SEC has disabled ftp access to EDGAR.
+        # Disabling tests until re-write.
+        pytest.skip("Disabling tests until re-write.")
+
     def test_get_full_index(self):
-        # As of December 31, SEC has disabled ftp access to EDGAR.  Disabling tests until re-write
-        raise nose.SkipTest()
         try:
             ed = web.DataReader('full', 'edgar-index')
             assert len(ed) > 1000
@@ -21,11 +25,9 @@ def test_get_full_index(self):
             tm.assert_index_equal(ed.columns, exp_columns)
 
         except RemoteDataError as e:
-            raise nose.SkipTest(e)
+            pytest.skip(e)
 
     def test_get_nonzip_index_and_low_date(self):
-        # As of December 31, SEC has disabled ftp access to EDGAR.  Disabling tests until re-write
-        raise nose.SkipTest()
         try:
             ed = web.DataReader('daily', 'edgar-index', '1994-06-30',
                                 '1994-07-02')
@@ -39,21 +41,18 @@ def test_get_nonzip_index_and_low_date(self):
             tm.assert_index_equal(ed.columns, exp_columns)
 
         except RemoteDataError as e:
-            raise nose.SkipTest(e)
+            pytest.skip(e)
 
     def test_get_gz_index_and_no_date(self):
-        # the test causes Travis timeout
-        raise nose.SkipTest()
+        # TODO: Rewrite, as this test causes Travis to timeout.
 
         try:
             ed = web.DataReader('daily', 'edgar-index')
             assert len(ed) > 2000
         except RemoteDataError as e:
-            raise nose.SkipTest(e)
+            pytest.skip(e)
 
     def test_6_digit_date(self):
-        # As of December 31, SEC has disabled ftp access to EDGAR.  Disabling tests until re-write
-        raise nose.SkipTest()
         try:
             ed = web.DataReader('daily', 'edgar-index', start='1998-05-18',
                                 end='1998-05-18')
@@ -70,9 +69,4 @@ def test_6_digit_date(self):
             tm.assert_index_equal(ed.columns, exp_columns)
 
         except RemoteDataError as e:
-            raise nose.SkipTest(e)
-
-
-if __name__ == '__main__':
-    nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],
-                   exit=False)
+            pytest.skip(e)

pandas_datareader/tests/test_edgar.py

@@ -1,13 +1,12 @@
 import os
+import pytest
 
 from requests.exceptions import HTTPError
 
-import nose
 import pandas.util.testing as tm
-from pandas_datareader.tests._utils import _skip_if_no_lxml
 
-import pandas_datareader.data as web
 import pandas_datareader as pdr
+import pandas_datareader.data as web
 
 TEST_API_KEY = os.getenv('ENIGMA_API_KEY')
 
@@ -17,23 +16,23 @@ class TestEnigma(tm.TestCase):
     @classmethod
     def setUpClass(cls):
         super(TestEnigma, cls).setUpClass()
-        _skip_if_no_lxml()
+        pytest.importorskip("lxml")
 
     def test_enigma_datareader(self):
         try:
             df = web.DataReader('enigma.inspections.restaurants.fl',
                                 'enigma', access_key=TEST_API_KEY)
             self.assertTrue('serialid' in df.columns)
         except HTTPError as e:  # pragma: no cover
-            raise nose.SkipTest(e)
+            pytest.skip(e)
 
     def test_enigma_get_data_enigma(self):
         try:
             df = pdr.get_data_enigma(
                 'enigma.inspections.restaurants.fl', TEST_API_KEY)
             self.assertTrue('serialid' in df.columns)
         except HTTPError as e:  # pragma: no cover
-            raise nose.SkipTest(e)
+            pytest.skip(e)
 
     def test_bad_key(self):
         with tm.assertRaises(HTTPError):
@@ -46,8 +45,3 @@ def test_bad_url(self):
             web.DataReader('enigma.inspections.restaurants.fllzzy',
                            'enigma',
                            access_key=TEST_API_KEY)
-
-
-if __name__ == '__main__':
-    nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],
-                   exit=False)

pandas_datareader/tests/test_enigma.py

@@ -1,5 +1,4 @@
-import nose
-import sys
+import pytest
 
 import numpy as np
 import pandas as pd
@@ -11,12 +10,6 @@
 
 class TestEurostat(tm.TestCase):
 
-    def setUp(self):
-
-        if sys.version_info < (2, 7, 0):
-            raise nose.SkipTest("Doesn't support Python 2.6 because of"
-                                "ElementTree incompat")
-
     def test_get_cdh_e_fos(self):
         # Employed doctorate holders in non managerial and non professional
         # occupations by fields of science (%)
@@ -72,10 +65,10 @@ def test_get_sts_cobp_a(self):
             tm.assert_series_equal(result, expected)
 
     def test_get_nrg_pc_202(self):
-        # GH 149
+        # see gh-149
 
         if not PANDAS_0170:
-            raise nose.SkipTest("skip because of comparison failure")
+            pytest.skip("skip because of comparison failure")
 
         df = web.DataReader('nrg_pc_202', 'eurostat',
                             start=pd.Timestamp('2010-01-01'),
@@ -97,14 +90,9 @@ def test_get_nrg_pc_202(self):
         tm.assert_series_equal(df[name], exp)
 
     def test_get_prc_hicp_manr_exceeds_limit(self):
-        # GH 149
+        # see gh-149
         msg = 'Query size exceeds maximum limit'
         with tm.assertRaisesRegexp(ValueError, msg):
             web.DataReader('prc_hicp_manr', 'eurostat',
                            start=pd.Timestamp('2000-01-01'),
                            end=pd.Timestamp('2013-01-01'))
-
-
-if __name__ == '__main__':
-    nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],
-                   exit=False)

pandas_datareader/tests/test_eurostat.py

@@ -1,12 +1,11 @@
-import nose
+import pytest
+
 import pandas as pd
 import pandas.util.testing as tm
 
 import pandas_datareader.data as web
 from pandas_datareader.famafrench import get_available_datasets
 
-from pandas_datareader.tests._utils import _skip_if_no_lxml
-
 
 class TestFamaFrench(tm.TestCase):
 
@@ -16,13 +15,14 @@ def test_get_data(self):
             '6_Portfolios_2x3', 'Portfolios_Formed_on_ME',
             'Prior_2-12_Breakpoints', 'ME_Breakpoints',
         ]
+
         for name in keys:
             ff = web.DataReader(name, 'famafrench')
             self.assertTrue('DESCR' in ff)
             self.assertTrue(len(ff) > 1)
 
     def test_get_available_datasets(self):
-        _skip_if_no_lxml()
+        pytest.importorskip("lxml")
         l = get_available_datasets()
         self.assertTrue(len(l) > 100)
 
@@ -80,8 +80,3 @@ def test_prior_2_12_breakpoints(self):
 
         exp_index = pd.period_range('2010-01-01', '2010-12-01', freq='M', name='Date')
         tm.assert_index_equal(results[0].index, exp_index)
-
-
-if __name__ == '__main__':
-    nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],
-                   exit=False)

pandas_datareader/tests/test_famafrench.py

@@ -1,22 +1,21 @@
 from datetime import datetime
 
+import pytest
+
 import numpy as np
 import pandas as pd
-from pandas import DataFrame
+import pandas.util.testing as tm
 import pandas_datareader.data as web
-from pandas_datareader._utils import RemoteDataError
 
-import nose
-import pandas.util.testing as tm
-from pandas.util.testing import assert_frame_equal
-from numpy.testing import assert_array_equal
+from pandas import DataFrame
+from pandas_datareader._utils import RemoteDataError
 
 
 class TestFred(tm.TestCase):
     def test_fred(self):
 
-        # Throws an exception when DataReader can't get a 200 response from
-        # FRED.
+        # Raises an exception when DataReader can't
+        # get a 200 response from FRED.
 
         start = datetime(2010, 1, 1)
         end = datetime(2013, 1, 1)
@@ -27,14 +26,8 @@ def test_fred(self):
         self.assertEqual(ts.index[-1], pd.to_datetime("2013-01-01"))
         self.assertEqual(ts.index.name, "DATE")
         self.assertEqual(ts.name, "GDP")
-        received = ts.tail(1)[0]
 
-        # < 2014-07-30 16535 was returned
-        # self.assertEqual(int(received), 16535)
-        # < 2015-08-20 16502 was returned
-        # self.assertEqual(int(received), 16502)
-        # < 2016-08-01 16440 was returned
-        # self.assertEqual(int(received), 16440)
+        received = ts.tail(1)[0]
         self.assertEqual(int(received), 16475)
 
         with tm.assertRaises(RemoteDataError):
@@ -46,9 +39,8 @@ def test_fred_nan(self):
         df = web.DataReader("DFII5", "fred", start, end)
         assert pd.isnull(df.ix['2010-01-01'][0])
 
+    @pytest.mark.skip(reason='Buggy as of 2/18/14; maybe a data revision?')
     def test_fred_parts(self):  # pragma: no cover
-        raise nose.SkipTest('buggy as of 2/18/14; maybe a data revision?')
-
         start = datetime(2010, 1, 1)
         end = datetime(2013, 1, 27)
         df = web.get_data_fred("CPIAUCSL", start, end)
@@ -65,14 +57,14 @@ def test_fred_part2(self):
                     [848.3],
                     [933.3]]
         result = web.get_data_fred("A09024USA144NNBR", start="1915").ix[:5]
-        assert_array_equal(result.values, np.array(expected))
+        tm.assert_numpy_array_equal(result.values, np.array(expected))
 
     def test_invalid_series(self):
         name = "NOT A REAL SERIES"
         self.assertRaises(Exception, web.get_data_fred, name)
 
+    @pytest.mark.skip(reason='Buggy as of 2/18/14; maybe a data revision?')
     def test_fred_multi(self):  # pragma: no cover
-        raise nose.SkipTest('buggy as of 2/18/14; maybe a data revision?')
         names = ['CPIAUCSL', 'CPALTT01USQ661S', 'CPILFESL']
         start = datetime(2010, 1, 1)
         end = datetime(2013, 1, 27)
@@ -81,14 +73,9 @@ def test_fred_multi(self):  # pragma: no cover
         expected = DataFrame([[217.478, 0.99701529, 220.544]], columns=names,
                              index=[pd.tslib.Timestamp('2010-01-01 00:00:00')])
         expected.index.rename('DATE', inplace=True)
-        assert_frame_equal(received, expected, check_less_precise=True)
+        tm.assert_frame_equal(received, expected, check_less_precise=True)
 
     def test_fred_multi_bad_series(self):
         names = ['NOTAREALSERIES', 'CPIAUCSL', "ALSO FAKE"]
         with tm.assertRaises(RemoteDataError):
             web.DataReader(names, data_source="fred")
-
-
-if __name__ == '__main__':
-    nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],
-                   exit=False)  # pragma: no cover