MAINT: deprecations (#1381)

* finally remove the "after 0.13" deprecations

* fix test

Author: drammock

src/pydata_sphinx_theme/__init__.py

@@ -36,16 +36,6 @@ def update_config(app):
             "The configuration `logo_text` is deprecated." "Use `'logo': {'text': }`."
         )
 
-    # TODO: deprecation; remove after 0.13 release
-    if theme_options.get("page_sidebar_items"):
-        theme_options["secondary_sidebar_items"] = theme_options.get(
-            "page_sidebar_items"
-        )
-        logger.warning(
-            "The configuration `page_sidebar_items` is deprecated."
-            "Use `secondary_sidebar_items`."
-        )
-
     # TODO: DEPRECATE after 0.14
     if theme_options.get("footer_items"):
         theme_options["footer_start"] = theme_options.get("footer_items")
@@ -71,14 +61,6 @@ def update_config(app):
     if not utils.config_provided_by_user(app, "html_permalinks_icon"):
         app.config.html_permalinks_icon = "#"
 
-    # Raise a warning for a deprecated theme switcher config
-    # TODO: deprecation; remove after 0.13 release
-    if "url_template" in theme_options.get("switcher", {}):
-        logger.warning(
-            "html_theme_options['switcher']['url_template'] is no longer supported."
-            " Set version URLs in JSON directly."
-        )
-
     # check the validity of the theme switcher file
     is_dict = isinstance(theme_options.get("switcher"), dict)
     should_test = theme_options.get("check_switcher", True)

tests/sites/deprecated/conf.py

@@ -23,11 +23,6 @@
 html_theme_options = {
     "search_bar_position": "navbar",
     "logo_text": "DOCS",
-    "page_sidebar_items": [
-        "page-toc.html",
-        "edit-this-page.html",
-        "sourcelink.html",
-    ],
     "footer_items": ["page-toc.html"],
     "favicons": [
         {

tests/test_build.py

@@ -790,11 +790,9 @@ def test_deprecated_build_html(sphinx_build_factory, file_regression) -> None:
     warnings = [w.lstrip("\x1b[91m").rstrip("\x1b[39;49;00m\n") for w in warnings]
     expected_warnings = (
         "The configuration `logo_text` is deprecated",
-        "The configuration `page_sidebar_items` is deprecated",
         "The configuration `favicons` is deprecated.",
         "`footer_items` is deprecated",
         "unsupported theme option 'logo_text'",
-        "unsupported theme option 'page_sidebar_items'",
     )
     assert len(warnings) == len(expected_warnings)
     for exp_warn in expected_warnings: