Fix encoding and decoding on big endian systems (#99)

Author: scaramallion

.github/workflows/pytest-builds.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
         arch: ['x64', 'x86']
 
     steps:
@@ -48,7 +48,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
 
     steps:
     - uses: actions/checkout@v4
@@ -82,7 +82,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
 
     steps:
     - uses: actions/checkout@v4
@@ -106,7 +106,7 @@ jobs:
         pytest --cov openjpeg openjpeg/tests
 
     - name: Install pydicom dev and rerun pytest (3.10+)
-      if: ${{ contains('3.10 3.11 3.12', matrix.python-version) }}
+      if: ${{ contains('3.10 3.11 3.12 3.13', matrix.python-version) }}
       run: |
         pip install pylibjpeg
         pip install git+https://github.com/pydicom/pydicom

.github/workflows/release-wheels.yml

@@ -42,9 +42,6 @@ jobs:
       matrix:
         include:
           # Windows 32 bit
-          - os: windows-latest
-            python: 38
-            platform_id: win32
           - os: windows-latest
             python: 39
             platform_id: win32
@@ -57,11 +54,11 @@ jobs:
           - os: windows-latest
             python: 312
             platform_id: win32
+          - os: windows-latest
+            python: 313
+            platform_id: win32
 
           # Windows 64 bit
-          - os: windows-latest
-            python: 38
-            platform_id: win_amd64
           - os: windows-latest
             python: 39
             platform_id: win_amd64
@@ -74,12 +71,11 @@ jobs:
           - os: windows-latest
             python: 312
             platform_id: win_amd64
+          - os: windows-latest
+            python: 313
+            platform_id: win_amd64
 
           # Linux 64 bit manylinux2014
-          - os: ubuntu-latest
-            python: 38
-            platform_id: manylinux_x86_64
-            manylinux_image: manylinux2014
           - os: ubuntu-latest
             python: 39
             platform_id: manylinux_x86_64
@@ -96,11 +92,12 @@ jobs:
             python: 312
             platform_id: manylinux_x86_64
             manylinux_image: manylinux2014
+          - os: ubuntu-latest
+            python: 313
+            platform_id: manylinux_x86_64
+            manylinux_image: manylinux2014
 
           # Linux aarch64
-          - os: ubuntu-latest
-            python: 38
-            platform_id: manylinux_aarch64
           - os: ubuntu-latest
             python: 39
             platform_id: manylinux_aarch64
@@ -113,11 +110,11 @@ jobs:
           - os: ubuntu-latest
             python: 312
             platform_id: manylinux_aarch64
+          - os: ubuntu-latest
+            python: 313
+            platform_id: manylinux_aarch64
 
           # MacOS 12 x86_64
-          - os: macos-12
-            python: 38
-            platform_id: macosx_x86_64
           - os: macos-12
             python: 39
             platform_id: macosx_x86_64
@@ -130,6 +127,9 @@ jobs:
           - os: macos-12
             python: 312
             platform_id: macosx_x86_64
+          - os: macos-12
+            python: 313
+            platform_id: macosx_x86_64
 
     steps:
     - uses: actions/checkout@v4
@@ -150,7 +150,7 @@ jobs:
     - name: Install cibuildwheel
       run: |
         python -m pip install -U pip
-        python -m pip install cibuildwheel>=2.16
+        python -m pip install cibuildwheel>=2.21
 
     - name: Build wheels (non-MacOS arm64)
       env:
@@ -179,9 +179,6 @@ jobs:
       matrix:
         include:
         # MacOS 14 arm64
-        - os: macos-14
-          python: 38
-          platform_id: macosx_arm64
         - os: macos-14
           python: 39
           platform_id: macosx_arm64
@@ -194,6 +191,9 @@ jobs:
         - os: macos-14
           python: 312
           platform_id: macosx_arm64
+        - os: macos-14
+          python: 313
+          platform_id: macosx_arm64
 
     steps:
     - uses: actions/checkout@v4
@@ -206,7 +206,7 @@ jobs:
         python-version: '3.9'
 
     - name: Install cibuildwheel
-      run: python -m pip install cibuildwheel==2.16.2 wheel==0.42
+      run: python -m pip install cibuildwheel>=2.21 wheel>=0.42
 
     - name: Build wheels
       env:
@@ -230,7 +230,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
 
     steps:
     - name: Set up Python ${{ matrix.python-version }}

build.py

@@ -2,6 +2,7 @@
 import os
 from pathlib import Path
 import shutil
+from struct import unpack
 import subprocess
 from typing import List, Any
 
@@ -24,6 +25,11 @@ def build(setup_kwargs: Any) -> Any:
 
     setup_oj()
 
+    # Determine if system is big endian or not
+    macros = [("NPY_NO_DEPRECATED_API", "NPY_1_7_API_VERSION")]
+    if unpack("h", b"\x00\x01")[0] == 1:
+        macros.append(("PYOJ_BIG_ENDIAN", None))
+
     ext = Extension(
         "_openjpeg",
         [os.fspath(p) for p in get_source_files()],
@@ -35,6 +41,7 @@ def build(setup_kwargs: Any) -> Any:
         ],
         extra_compile_args=[],
         extra_link_args=[],
+        define_macros=macros,
     )
 
     ext_modules = cythonize(