Do not silently rename, allow exceptions/error to be caught.

cdujeu · cdujeu · commit afe154748688 · 2016-10-11T09:58:26.000+02:00
diff --git a/core/src/plugins/access.fs/FsAccessDriver.php b/core/src/plugins/access.fs/FsAccessDriver.php
@@ -2079,7 +2079,7 @@ public function rename($originalNode, $dest = null, $filename_new = null)
             throw new PydioException($mess[100]." ".$originalNode->getPath());
         }
         Controller::applyHook("node.before_path_change", [&$originalNode]);
-        $test = @rename($originalNode->getUrl(),$newNode->getUrl());
+        $test = rename($originalNode->getUrl(),$newNode->getUrl());
         if($test === false){
             throw new \Exception("Error while renaming ".$originalNode->getPath()." to ".$newNode->getPath());
         }

Original file line number	Diff line number	Diff line change
`@@ -2079,7 +2079,7 @@ public function rename($originalNode, $dest = null, $filename_new = null)`
`2079`	`2079`	`throw new PydioException($mess[100]." ".$originalNode->getPath());`
`2080`	`2080`	`}`
`2081`	`2081`	`Controller::applyHook("node.before_path_change", [&$originalNode]);`
`2082`		`- $test = @rename($originalNode->getUrl(),$newNode->getUrl());`
	`2082`	`+ $test = rename($originalNode->getUrl(),$newNode->getUrl());`
`2083`	`2083`	`if($test === false){`
`2084`	`2084`	`throw new \Exception("Error while renaming ".$originalNode->getPath()." to ".$newNode->getPath());`
`2085`	`2085`	`}`