Fix mergeNodes: use cloneNode() to avoid reference mess up.

cdujeu · cdujeu · commit c671c551ac61 · 2015-10-23T13:34:21.000+02:00
diff --git a/core/src/core/classes/class.AJXP_PluginsService.php b/core/src/core/classes/class.AJXP_PluginsService.php
@@ -793,7 +793,7 @@ protected function mergeChildByTagName($new, &$old)
                 if ($newChild->nodeName == "post_processing" || $newChild->nodeName == "pre_processing") {
                     $old->appendChild($newChild->cloneNode(true));
                 } else {
-                    $this->mergeChildByTagName($newChild, $found);
+                    $this->mergeChildByTagName($newChild->cloneNode(true), $found);
                 }
             } else {
                 // CloneNode or it's messing with the current foreach loop.

Original file line number	Diff line number	Diff line change
`@@ -793,7 +793,7 @@ protected function mergeChildByTagName($new, &$old)`
`793`	`793`	`if ($newChild->nodeName == "post_processing" \|\| $newChild->nodeName == "pre_processing") {`
`794`	`794`	`$old->appendChild($newChild->cloneNode(true));`
`795`	`795`	`} else {`
`796`		`- $this->mergeChildByTagName($newChild, $found);`
	`796`	`+ $this->mergeChildByTagName($newChild->cloneNode(true), $found);`
`797`	`797`	`}`
`798`	`798`	`} else {`
`799`	`799`	`// CloneNode or it's messing with the current foreach loop.`