User.js Detect and log circular references

Fix circular references in AjxpTabulator (init Tab with object clone).

Author: cdujeu

core/src/plugins/gui.ajax/res/js/ajaxplorer.js

@@ -641,11 +641,14 @@ Class.create("AjxpTabulator", AjxpPane, {
                     pair.value.TAB.dontFocus = true;
                     window.setTimeout(function(){
                         if(!$(this.htmlElement)) return;
-                        this.addTab(pair.value.TAB, pair.value.PANE, true);
+                        this.addTab(Object.clone(pair.value.TAB), Object.clone(pair.value.PANE), true);
+                        if(pair.value.DATA){
+                            var object = this.getAjxpObjectByTabId(pair.key);
+                            if(object && object.loadStateData) object.loadStateData(pair.value.DATA);
+                        }
                     }.bind(this), index * 2000);
                     index ++;
-                }
-                if(pair.value.DATA){
+                }else  if(pair.value.DATA){
                     var object = this.getAjxpObjectByTabId(pair.key);
                     if(object && object.loadStateData) object.loadStateData(pair.value.DATA);
                 }

core/src/plugins/gui.ajax/res/js/ajaxplorer/class.AjxpTabulator.js

@@ -182,7 +182,35 @@ Class.create("User", {
 	setPreference : function(prefName, prefValue, toJSON){
 		if(toJSON){
             this._parsedJSONCache.unset(prefName);
-			prefValue = Object.toJSON(prefValue);
+            try{
+    			prefValue = Object.toJSON(prefValue);
+            }catch (e){
+                if(console) {
+                    function isCyclic (obj) {
+                        var seenObjects = [];
+
+                        function detect (obj) {
+                            if (obj && typeof obj === 'object') {
+                                if (seenObjects.indexOf(obj) !== -1) {
+                                    return true;
+                                }
+                                seenObjects.push(obj);
+                                for (var key in obj) {
+                                    if (obj.hasOwnProperty(key) && detect(obj[key])) {
+                                        console.log(obj, 'cycle at ' + key);
+                                        return true;
+                                    }
+                                }
+                            }
+                            return false;
+                        }
+                        return detect(obj);
+                    }
+                    console.log("Caught toJSON error " + e.message, prefValue, isCyclic(prefValue));
+
+                }
+                return;
+            }
 		}
 		this.preferences.set(prefName, prefValue);
 	},