Hunt down all is_a calls.

Author: cdujeu

core/src/plugins/core.access/src/Filter/AJXP_PermissionMask.php

@@ -179,14 +179,14 @@ private function mergeTrees($t1, $t2){
                 continue;
             }
             $value1 = $t1[$key];
-            if(is_a($value1, "AJXP_Permission") && is_a($value2, "AJXP_Permission")){
+            if($value1 instanceof AJXP_Permission && $value2 instanceof AJXP_Permission){
                 /**
                  * @var AJXP_Permission $value2
                  */
                 $result[$key] = $value2->override($value1);
-            }else if(is_a($value1, "AJXP_Permission")){
+            }else if($value1 instanceof AJXP_Permission){
                 $result[$key] = $value2;
-            }else if(is_a($value2, "AJXP_Permission")){
+            }else if($value2 instanceof AJXP_Permission){
                 /**
                  * @var AJXP_Permission $value2
                  */
@@ -237,7 +237,7 @@ public function flattenTree($tree = null, &$pathes = null, $currentRoot=""){
         if($pathes == null) $pathes = array();
         if(!is_array($tree) || $tree == null) $tree = array();
         foreach($tree as $pathPart => $value){
-            if(is_a($value, "AJXP_Permission")){
+            if($value instanceof AJXP_Permission){
                 $pathes[$currentRoot."/".$pathPart] = $value;
             }else{
                 $this->flattenTree($value, $pathes, $currentRoot."/".$pathPart);

core/src/plugins/core.access/src/MetaStreamWrapper.php

@@ -24,6 +24,7 @@
 use Normalizer;
 use Pydio\Access\Core\Filter\ContentFilter;
 use Pydio\Access\Core\Model\AJXP_Node;
+use Pydio\Access\Core\Model\Repository;
 use Pydio\Core\Exception\PydioException;
 use Pydio\Core\Model\ContextInterface;
 
@@ -251,7 +252,7 @@ protected static function actualRepositoryWrapperData(AJXP_Node $node){
             return self::$cachedRepositoriesWrappers[$repositoryId];
         }
         $repository = RepositoryService::getRepositoryById($repositoryId);
-        if(!is_a($repository, "Repository")){
+        if(!$repository instanceof Repository){
             throw new \Exception("Cannot find repository with this id!");
         }
         if(self::detectWrapperForNode($node, false, $streams, $streamData)){

core/src/plugins/core.access/src/Model/Repository.php

@@ -24,7 +24,6 @@
 use Pydio\Access\Core\Filter\ContentFilter;
 use Pydio\Core\Exception\PydioException;
 use Pydio\Core\Exception\RepositoryLoadException;
-use Pydio\Core\Model\Context;
 use Pydio\Core\Model\ContextInterface;
 use Pydio\Core\Model\RepositoryInterface;
 
@@ -357,7 +356,7 @@ public function getSafeOption($oName){
     public function getContextOption(ContextInterface $ctx, $oName, $default = null){
         if(isSet($this->inferOptionsFromParent) && isSet($this->parentId)){
             $parentTemplateObject = RepositoryService::getRepositoryById($this->parentId);
-            if(empty($parentTemplateObject) || !is_a($parentTemplateObject, "Repository")) {
+            if(empty($parentTemplateObject) || !$parentTemplateObject instanceof Repository) {
                 throw new PydioException("Option should be loaded from parent repository, but it was not found");
             }
         }