Make sure to never call getRepositoriesList() on "user" scope before the user is actually logged, otherwise it caches an incomplete list (e.g. in updateDefaultRights). Fixes incomplete list in sync client sometime, and make fix some issues with default rights as well.

Author: cdujeu

core/src/core/classes/class.AuthService.php

@@ -632,7 +632,7 @@ public static function updateDefaultRights(&$userObject)
     {
         if (!$userObject->hasParent()) {
             $changes = false;
-            $repoList = ConfService::getRepositoriesList();
+            $repoList = ConfService::getRepositoriesList("all");
             foreach ($repoList as $repositoryId => $repoObject) {
                 if(!self::allowedForCurrentGroup($repoObject, $userObject)) continue;
                 if($repoObject->isTemplate) continue;

core/src/core/classes/class.ConfService.php

@@ -350,6 +350,7 @@ public function switchRootDirInst($rootDirIndex=-1, $temporary=false)
      * See instance method
      * @static
      * @param String $scope "user" or "all"
+     * @param bool $includeShared
      * @return Repository[]
      */
     public static function getRepositoriesList($scope = "user", $includeShared = true)

core/src/plugins/action.scheduler/class.AjxpScheduler.php

@@ -78,7 +78,7 @@ public function parseSpecificContributions(&$contribNode)
         if(!$paramList->length) return;
         $paramNode = $paramList->item(0);
         $sVals = array();
-        $repos = ConfService::getRepositoriesList();
+        $repos = ConfService::getRepositoriesList("all");
         foreach ($repos as $repoId => $repoObject) {
             $sVals[] = $repoId."|". AJXP_Utils::xmlEntities($repoObject->getDisplay());
         }
@@ -189,7 +189,7 @@ public function runTask($taskId, $status = null, &$currentlyRunning = -1, $force
                 $data["user_id"] = "queue:".$tmpQueue;
             }
             if ($data["repository_id"] == "*") {
-                $data["repository_id"] = implode(",", array_keys(ConfService::getRepositoriesList()));
+                $data["repository_id"] = implode(",", array_keys(ConfService::getRepositoriesList("all")));
             }
             $process = AJXP_Controller::applyActionInBackground(
                 $data["repository_id"],