Updated type annotations of student_id and course_id in example.

Author: johnbywater

examples/coursebooking/application.py

@@ -31,28 +31,28 @@ def register_course(self, name: str, places: int) -> CourseID:
         self.save(course)
         return course.id
 
-    def join_course(self, student_id: str, course_id: str) -> None:
+    def join_course(self, student_id: StudentID, course_id: CourseID) -> None:
         course = self.get_course(course_id)
         student = self.get_student(student_id)
         course.accept_student(student_id)
         student.join_course(course_id)
         self.save(course, student)
 
-    def list_students_for_course(self, course_id: str) -> list[str]:
+    def list_students_for_course(self, course_id: CourseID) -> list[str]:
         course = self.get_course(course_id)
         return [self.get_student(s).name for s in course.student_ids]
 
-    def list_courses_for_student(self, student_id: str) -> list[str]:
+    def list_courses_for_student(self, student_id: StudentID) -> list[str]:
         student = self.get_student(student_id)
         return [self.get_course(s).name for s in student.course_ids]
 
-    def get_student(self, student_id: str) -> Student:
+    def get_student(self, student_id: StudentID) -> Student:
         try:
             return self.repository.get(student_id)
         except AggregateNotFoundError:
             raise StudentNotFoundError from None
 
-    def get_course(self, course_id: str) -> Course:
+    def get_course(self, course_id: CourseID) -> Course:
         try:
             return self.repository.get(course_id)
         except AggregateNotFoundError:

examples/coursebooking/domainmodel.py

@@ -60,10 +60,10 @@ def create_id() -> StudentID:
     def __init__(self, name: str, max_courses: int) -> None:
         self.name = name
         self.max_courses = max_courses
-        self.course_ids: list[str] = []
+        self.course_ids: list[CourseID] = []
 
     @event("CourseJoined")
-    def join_course(self, course_id: str) -> None:
+    def join_course(self, course_id: CourseID) -> None:
         if len(self.course_ids) >= self.max_courses:
             raise TooManyCoursesError
         self.course_ids.append(course_id)
@@ -77,10 +77,10 @@ def create_id() -> CourseID:
     def __init__(self, name: str, places: int) -> None:
         self.name = name
         self.places = places
-        self.student_ids: list[str] = []
+        self.student_ids: list[StudentID] = []
 
     @event("StudentAccepted")
-    def accept_student(self, student_id: str) -> None:
+    def accept_student(self, student_id: StudentID) -> None:
         if len(self.student_ids) >= self.places:
             raise FullyBookedError
         if student_id in self.student_ids: