-
Notifications
You must be signed in to change notification settings - Fork 4k
Open
Labels
Description
π Describe the documentation issue
Hi PyG team,
Currently, the ResGatedGraphConv documentation shows the equations:
with
This is accurate when no edge features are provided. However, in the implementation, when edge_attr is passed, it is concatenated to the node features before computing the key, query, and value projections:
if edge_attr is not None:
k_i = self.lin_key(torch.cat([k_i, edge_attr], dim=-1))
q_j = self.lin_query(torch.cat([q_j, edge_attr], dim=-1))
v_j = self.lin_value(torch.cat([v_j, edge_attr], dim=-1))Thus, the actual behavior is closer to:
where (
Suggest a potential alternative/fix
No response
Reactions are currently unavailable