Skip to content

Commit 0de7425

Browse files
committed
Check isinstance(f, bool) just once
1 parent f990781 commit 0de7425

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

galgebra/mv.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -181,17 +181,16 @@ def add_superscript(root, s):
181181
if utils.isstr(__name_or_coeffs):
182182
name = __name_or_coeffs
183183
f = kwargs['f']
184-
if isinstance(f, bool) and not f: #Is a constant mulitvector function
185-
return sum([Symbol(add_superscript(name, super_script), real=True) * base
186-
for (super_script, base) in zip(ga.blade_super_scripts[grade], ga.blades[grade])])
187-
188-
else:
189-
if isinstance(f, bool): #Is a multivector function of all coordinates
184+
if isinstance(f, bool):
185+
if f: # Is a multivector function of all coordinates
190186
return sum([Function(add_superscript(name, super_script), real=True)(*ga.coords) * base
191-
for (super_script, base) in zip(ga.blade_super_scripts[grade], ga.blades[grade])])
192-
else: #Is a multivector function of tuple f variables
193-
return sum([Function(add_superscript(name, super_script), real=True)(*f) * base
194-
for (super_script, base) in zip(ga.blade_super_scripts[grade], ga.blades[grade])])
187+
for (super_script, base) in zip(ga.blade_super_scripts[grade], ga.blades[grade])])
188+
else: # Is a constant multivector function
189+
return sum([Symbol(add_superscript(name, super_script), real=True) * base
190+
for (super_script, base) in zip(ga.blade_super_scripts[grade], ga.blades[grade])])
191+
else: # Is a multivector function of tuple f variables
192+
return sum([Function(add_superscript(name, super_script), real=True)(*f) * base
193+
for (super_script, base) in zip(ga.blade_super_scripts[grade], ga.blades[grade])])
195194
elif isinstance(__name_or_coeffs, (list, tuple)):
196195
coeffs = __name_or_coeffs
197196
if len(coeffs) <= len(ga.blades[grade]):

0 commit comments

Comments
 (0)