Skip to content

Commit 28bc58e

Browse files
committed
Simplify er_blade
This function did two things unnecessarily: * Convert blade reps to base rep before calling mul. This is already handled within `mul`, so there's no need to do it again at the call site. * Branch depending on the mode string - this branching is already handled by `Mul`
1 parent 159cc2a commit 28bc58e

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

galgebra/ga.py

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1683,22 +1683,10 @@ def er_blade(self, er, blade, mode='*', left=True):
16831683
16841684
.. math:: e^{j}*(e_{i_{1}}\wedge ...\wedge e_{i_{r}})
16851685
"""
1686-
if mode == '*':
1687-
base = self.blade_to_base_rep(blade)
1688-
if left:
1689-
return self.base_to_blade_rep(self.mul(er, base))
1690-
else:
1691-
return self.base_to_blade_rep(self.mul(base, er))
1692-
elif mode == '^':
1693-
if left:
1694-
return self.wedge(er, blade)
1695-
else:
1696-
return self.wedge(blade, er)
1686+
if left:
1687+
return self.Mul(er, blade, mode=mode)
16971688
else:
1698-
if left:
1699-
return self._dot(er, blade, mode=mode)
1700-
else:
1701-
return self._dot(blade, er, mode=mode)
1689+
return self.Mul(blade, er, mode=mode)
17021690

17031691
def blade_derivation(self, blade, ib):
17041692
"""

0 commit comments

Comments
 (0)