Skip to content

Commit 7ee4fd4

Browse files
authored
Merge pull request #73 from eric-wieser/fix-lgtm-errors
Fix some LGTM.com errors
2 parents 9797860 + bc71f2e commit 7ee4fd4

File tree

4 files changed

+2
-19
lines changed

4 files changed

+2
-19
lines changed

galgebra/ga.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1256,7 +1256,7 @@ def Mul(self, A, B, mode='*'): # Unifies all products into one function
12561256
elif mode == '^':
12571257
return self.wedge(A, B)
12581258
else:
1259-
return self.dot(A, B, mode=mode)
1259+
return self._dot(A, B, mode=mode)
12601260

12611261
def mul(self, A, B): # geometric (*) product of blade representations
12621262
if A == 0 or B == 0:

galgebra/lt.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ def __call__(self, v, obj=False):
244244
if self.spinor:
245245
if not isinstance(v, mv.Mv):
246246
v = mv.Mv(v, ga=self.Ga)
247-
if self.rho_sq == None:
247+
if self.rho_sq is None:
248248
R_v_Rrev = self.R * v * self.Rrev
249249
else:
250250
R_v_Rrev = self.rho_sq * self.R * v * self.Rrev

galgebra/metric.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,6 @@ def apply_function_list(f,x):
2323
else:
2424
return f(x)
2525

26-
def str_to_lst(s):
27-
if '[' in s:
28-
s = s.replace('[', '')
29-
if ']' in s:
30-
s = s.replace(']', '')
31-
s_lst = s.split(',')
32-
v_lst = []
33-
for x in s_lst:
34-
try:
35-
v_lst.append(int(s))
36-
except ValueError:
37-
v_lst.append(Symbol(s, real=True))
38-
return v_lst
39-
4026

4127
def linear_expand(expr, mode=True):
4228

galgebra/mv.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ def Mul(A, B, op):
110110
return A > B
111111
else:
112112
raise ValueError('Operation ' + op + 'not allowed in Mv.Mul!')
113-
return
114113

115114
def characterise_Mv(self):
116115
if self.char_Mv:
@@ -1176,7 +1175,6 @@ def Fmt(self, fmt=1, title=None):
11761175
return title + ' = ' + s
11771176
else:
11781177
return s
1179-
return
11801178

11811179
def _repr_latex_(self):
11821180
latex_str = printer.GaLatexPrinter.latex(self)
@@ -2408,7 +2406,6 @@ def Fmt(self, fmt=1, title=None, dop_fmt=None):
24082406
return title + ' = ' + s
24092407
else:
24102408
return s
2411-
return
24122409

24132410
@staticmethod
24142411
def basic(ga):

0 commit comments

Comments
 (0)