Deprecate mv_I and mx_x

No one should be using these, there are better alternatives

Author: eric-wieser

galgebra/ga.py

@@ -484,14 +484,22 @@ def I(self):  # Noromalized pseudo-scalar
     @property
     def mv_I(self):
         # This exists for backwards compatibility. Note this is not `I()`!
+        # galgebra 0.4.5
+        warnings.warn(
+            "`ga.mv_I` is deprecated, use `ga.E()` instead, or perhaps `ga.I()`",
+            DeprecationWarning, stacklevel=2)
         # default pseudoscalar
         return self.E()
 
     @property
     def mv_x(self):
         # This exists for backwards compatibility.
+        # galgebra 0.4.5
+        warnings.warn(
+            "`ga.mv_x` is deprecated, use `ga.mv(your_name, 'vector')` instead",
+            DeprecationWarning, stacklevel=2)
         # testing vectors
-        return Mv('XxXx', 'vector', ga=self)
+        return mv.Mv('XxXx', 'vector', ga=self)
 
     def X(self):
         return self.mv(sum([coord*base for (coord, base) in zip(self.coords, self.basis)]))

test/test_mv.py

@@ -1,10 +1,19 @@
 import unittest
+
+import pytest
 from sympy import Symbol
 from galgebra.ga import Ga
 from galgebra import utils
 
 class TestMv(unittest.TestCase):
 
+    def test_deprecations(self):
+        ga, e_1, e_2, e_3 = Ga.build('e*1|2|3')
+        with pytest.warns(DeprecationWarning):
+            ga.mv_x
+        with pytest.warns(DeprecationWarning):
+            ga.mv_I
+
     def test_is_base(self):
         """
         Various tests on several multivectors.