Skip to content

Conversation

@eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 18, 2019

_dot was removed in gh-142, but when inlining, this call site was missed.

Coverage will be zero, but I'll handle adding that in #140

`_dot` was removed in pygaegh-142, but when inlining, this call site was missed.
@eric-wieser eric-wieser added this to the 0.4.5 milestone Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #181 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   67.84%   67.76%   -0.09%     
==========================================
  Files           9        9              
  Lines        4684     4684              
==========================================
- Hits         3178     3174       -4     
- Misses       1506     1510       +4
Impacted Files Coverage Δ
galgebra/ga.py 73.43% <0%> (ø) ⬆️
galgebra/mv.py 64.39% <0%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce4920...bbe8df1. Read the comment docs.

@utensil utensil merged commit fc4585a into pygae:master Dec 18, 2019
@eric-wieser eric-wieser deleted the fix-er_blade-AttributeError branch May 26, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants