Get rid of PG_SURF_BitsPerPixel

It's inconsistent between SDL2 and SDL3, and I see no way to fix it.

In SDL2, (surf->format->BitsPerPixel), the value means the number of bits each pixel occupies in total. For example, RGBX => 32.

In SDL3, (SDL_BITSPERPIXEL(surf->format)), the value means the number of pixels occupied by the pixel's data, not including padding. So RGBX => 24.

These changes reduce SDL3 unit test failures.

Revert "Get rid of PG_SURF_BitsPerPixel"

This reverts commit 1276caa.

Fix PG_SURF_BitsPerPixel SDL3 implementation

Author: Starbuck5

src_c/_pygame.h

@@ -105,7 +105,32 @@ PG_UnlockMutex(SDL_mutex *mutex)
     return 0;
 }
 
-#define PG_SURF_BitsPerPixel(surf) SDL_BITSPERPIXEL(surf->format)
+// Implementation from SDL_GetMasksForPixelFormat, which is used by
+// SDL_InitPixelFormatDetails in SDL_pixels.c
+// Created to match surf->format->BitsPerPixel in SDL2,
+// details->bits_per_pixel in SDL3.
+static inline int
+PG_SURF_BitsPerPixel(SDL_Surface *surf)
+{
+    if (SDL_ISPIXELFORMAT_FOURCC(surf->format)) {
+        // however, some of these are packed formats, and can legit declare
+        // bits-per-pixel!
+        switch (surf->format) {
+            case SDL_PIXELFORMAT_YUY2:
+            case SDL_PIXELFORMAT_UYVY:
+            case SDL_PIXELFORMAT_YVYU:
+                return 32;
+            default:
+                return 0;  // oh well.
+        }
+    }
+
+    if (SDL_BYTESPERPIXEL(surf->format) <= 2) {
+        return SDL_BITSPERPIXEL(surf->format);
+    }
+    return SDL_BYTESPERPIXEL(surf->format) * 8;
+}
+
 #define PG_SURF_BytesPerPixel(surf) SDL_BYTESPERPIXEL(surf->format)
 #define PG_FORMAT_BitsPerPixel(format) format->bits_per_pixel
 #define PG_FORMAT_BytesPerPixel(format) format->bytes_per_pixel