support float input, add test

Author: yunline

src_c/mixer.c

@@ -1165,12 +1165,22 @@ chan_set_source_location(PyObject *self, PyObject *args)
 {
     int channelnum = pgChannel_AsInt(self);
     Sint16 angle;
+    float angle_f;
     Uint8 distance;
+    float distance_f;
     PyThreadState *_save;
 
-    if (!PyArg_ParseTuple(args, "hb", &angle, &distance))
+    if (!PyArg_ParseTuple(args, "ff", &angle_f, &distance_f))
         return NULL;
 
+    angle = (Sint16)roundf(fmodf(angle_f, 360));
+    distance_f = roundf(distance_f);
+    if (0 > distance_f || 256 <= distance_f) {
+        return RAISE(PyExc_ValueError,
+                     "distance out of range, expected (0, 255)");
+    }
+    distance = (Uint8)distance_f;
+
     MIXER_INIT_CHECK();
     _save = PyEval_SaveThread();
     if (!Mix_SetPosition(channelnum, angle, distance)) {

test/mixer_test.py

@@ -898,6 +898,13 @@ def todo_test_unpause(self):
 
         self.fail()
 
+    def test_set_source_location(self):
+        ch = mixer.Channel(0)
+        ch.set_source_location(-3.14, 6.25)
+        self.assertRaises(ValueError, lambda: ch.set_source_location(0, -1))
+        self.assertRaises(ValueError, lambda: ch.set_source_location(0, 256.0))
+        self.assertRaises(TypeError, lambda: ch.set_source_location("", 6.25))
+
 
 class ChannelInteractiveTest(unittest.TestCase):
     __tags__ = ["interactive"]