use SDL_SetPixelFormatPalette

Temmie3754 · Temmie3754 · commit e79f35c2f2ef · 2023-03-30T23:29:32.000+01:00
diff --git a/src_c/surface.c b/src_c/surface.c
@@ -1561,15 +1561,15 @@ surf_convert(pgSurfaceObject *self, PyObject *args)
                     format.BitsPerPixel, format.Rmask, format.Gmask,
                     format.Bmask, format.Amask))) {
                 if (SDL_ISPIXELFORMAT_INDEXED(surf->format->format)) {
-                    format.palette = surf->format->palette;
+                    SDL_SetPixelFormatPalette(&format, surf->format->palette);
                 }
                 else {
                     /* Give the surface something other than an all white
                      * palette.
                      */
                     SDL_SetPaletteColors(palette, default_palette_colors, 0,
                                          default_palette_size);
-                    format.palette = palette;
+                    SDL_SetPixelFormatPalette(&format, palette);
                 }
             }
             newsurf = SDL_ConvertSurface(surf, &format, 0);

Original file line number	Diff line number	Diff line change
`@@ -1561,15 +1561,15 @@ surf_convert(pgSurfaceObject self, PyObject args)`
`1561`	`1561`	`format.BitsPerPixel, format.Rmask, format.Gmask,`
`1562`	`1562`	`format.Bmask, format.Amask))) {`
`1563`	`1563`	`if (SDL_ISPIXELFORMAT_INDEXED(surf->format->format)) {`
`1564`		`- format.palette = surf->format->palette;`
	`1564`	`+ SDL_SetPixelFormatPalette(&format, surf->format->palette);`
`1565`	`1565`	`}`
`1566`	`1566`	`else {`
`1567`	`1567`	`/* Give the surface something other than an all white`
`1568`	`1568`	`* palette.`
`1569`	`1569`	`*/`
`1570`	`1570`	`SDL_SetPaletteColors(palette, default_palette_colors, 0,`
`1571`	`1571`	`default_palette_size);`
`1572`		`- format.palette = palette;`
	`1572`	`+ SDL_SetPixelFormatPalette(&format, palette);`
`1573`	`1573`	`}`
`1574`	`1574`	`}`
`1575`	`1575`	`newsurf = SDL_ConvertSurface(surf, &format, 0);`