Skip to content

SDL3: FRect changes, what to do?ย #3571

@ankith26

Description

@ankith26

So SDL3 has introduced some FRect changes that break our FRect.clipline tests (ref: libsdl-org/SDL#6791 (comment))

TL;DR is the changes make FRect operations more mathematically correct (SDL2 FRect would handle top/left edges differently from bottom/right edges) but the changes are inconsistent with regular Rect.clipline which notably hasn't changed since SDL2.

We now have two options:

  1. Retain SDL2 behaviour.
  2. Switch to SDL3 behaviour.

Given FRect is pygame-ce specific functionality introduced not too long ago, I think switching to SDL3 way of doing things right away isnt a bad idea. Opening this issue to get more people's opinions on this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions