FIX(TCs): don't cretae Ops EARLY in pytest-params ...

not to confuse debugging other TCs, AND
not to crash early, during refactorings.

Author: ankostis

test/test_base.py

@@ -148,14 +148,14 @@ def compute(self, named_inputs, outputs=None):
     [
         # NO old-stuff Operation(fn=_jetsamed_fn, name="test", needs="['a']", provides=[]),
         (
-            fnt.partial(
+            lambda: fnt.partial(
                 operation(name="test", needs=["a"], provides=["b"])(_scream).compute,
                 named_inputs={"a": 1},
             ),
             "outputs provides aliases results_fn results_op operation args".split(),
         ),
         (
-            fnt.partial(
+            lambda: fnt.partial(
                 network.ExecutionPlan(*([None] * 6))._handle_task,
                 op=_ScreamingOperation(),
                 solution=Solution(MagicMock(), {}),
@@ -168,6 +168,7 @@ def compute(self, named_inputs, outputs=None):
 )
 def test_jetsam_sites_screaming_func(acallable, expected_jetsam):
     # Check jetsams when the underlying function fails.
+    acallable = acallable()
     with pytest.raises(Exception, match="ABC") as excinfo:
         acallable()
 
@@ -181,11 +182,13 @@ def test_jetsam_sites_screaming_func(acallable, expected_jetsam):
     [
         # NO old-stuff Operation(fn=_jetsamed_fn, name="test", needs="['a']", provides=[]),
         (
-            fnt.partial(operation(_scream, name="test")().compute, named_inputs=None),
+            lambda: fnt.partial(
+                operation(_scream, name="test")().compute, named_inputs=None
+            ),
             "outputs provides aliases results_fn results_op operation args".split(),
         ),
         (
-            fnt.partial(
+            lambda: fnt.partial(
                 network.ExecutionPlan(*([None] * 6))._handle_task,
                 op=operation(_scream, name="Ah!")(),
                 solution=Solution(MagicMock(), {}),
@@ -194,13 +197,13 @@ def test_jetsam_sites_screaming_func(acallable, expected_jetsam):
             "plan solution task".split(),
         ),
         (
-            fnt.partial(
+            lambda: fnt.partial(
                 network.ExecutionPlan(*([None] * 6)).execute, named_inputs=None
             ),
             ["solution"],
         ),
         (
-            fnt.partial(
+            lambda: fnt.partial(
                 NetworkOperation([operation(str)()], "name").compute,
                 named_inputs=None,
                 outputs="bad",
@@ -211,6 +214,7 @@ def test_jetsam_sites_screaming_func(acallable, expected_jetsam):
 )
 def test_jetsam_sites_scream(acallable, expected_jetsam):
     # Check jetsams when the site fails.
+    acallable = acallable()
     with pytest.raises(Exception) as excinfo:
         acallable()
 
@@ -482,7 +486,7 @@ def test_func_sourcelines_func(fn):
     exp = "def _foo():\n    pass"
     got = base.func_sourcelines(fn, human=1)
     assert "".join(got[0]).strip() == exp
-    assert got[1] == 225
+    assert got[1] == 229
 
 
 @pytest.mark.parametrize(
@@ -499,7 +503,7 @@ def test_func_sourcelines_method(fn):
     exp = "def foo(self):\n        pass"
     got = base.func_sourcelines(fn, human=1)
     assert "".join(got[0]).strip() == exp
-    assert got[1] == 230
+    assert got[1] == 234
 
 
 @pytest.mark.parametrize("fn", [eval, fnt.partial(eval)])

test/test_op.py

@@ -292,31 +292,29 @@ def test_as_renames(inp, exp):
 
 
 @pytest.mark.parametrize(
-    "opbuilder, ex",
+    "op_kw, ex",
     [
         (
-            operation(str, aliases={"a": 1}),
+            dict(aliases={"a": 1}),
             r"The `aliases` for ['a'] rename ['a'], not found in op_provides []!",
         ),
         (
-            operation(str, name="t", provides="a", aliases={"a": 1, "b": 2}),
+            dict(name="t", provides="a", aliases={"a": 1, "b": 2}),
             r"The `aliases` for ['a', 'b'] rename ['b'], not found in op_provides ['a']!",
         ),
         (
-            operation(
-                str, name="t", provides=sideffect("a"), aliases={sideffect("a"): 1}
-            ),
+            dict(name="t", provides=sideffect("a"), aliases={sideffect("a"): 1}),
             "must not contain `sideffects",
         ),
         (
-            operation(str, name="t", provides="a", aliases={"a": sideffect("AA")}),
+            dict(name="t", provides="a", aliases={"a": sideffect("AA")}),
             "must not contain `sideffects",
         ),
     ],
 )
-def test_provides_aliases_BAD(opbuilder, ex):
+def test_provides_aliases_BAD(op_kw, ex):
     with pytest.raises(ValueError, match=re.escape(ex)):
-        opbuilder()
+        operation(str, **op_kw)()
 
 
 def test_provides_aliases():
@@ -498,7 +496,13 @@ def _opsattrs(ops, attr, value):
 
 
 @pytest.mark.parametrize(
-    "op", [Operation, FunctionalOperation, operation(str)(), operation(lambda: None)()]
+    "op_fact",
+    [
+        lambda: Operation,
+        lambda: FunctionalOperation,
+        lambda: operation(str)(),
+        lambda: operation(lambda: None)(),
+    ],
 )
-def test_dill_ops(op):
-    dill.loads(dill.dumps(op))
+def test_dill_ops(op_fact):
+    dill.loads(dill.dumps(op_fact()))