DROP(fnop) MultiValueError hindered debug

Author: ankostis

graphtik/base.py

@@ -33,12 +33,6 @@
 log = logging.getLogger(__name__)
 
 
-class MultiValueError(ValueError):
-    def __str__(self):
-        """Assuming it has been called with ``MultiValueError(msg, ex1, ...) #"""
-        return str(self.args[0])  # pylint: disable=unsubscriptable-object
-
-
 class AbortedException(Exception):
     """
     Raised from Network when :func:`.abort_run()` is called, and contains the solution ...

graphtik/config.py

@@ -88,7 +88,6 @@ def _tristate_armed(context_var: ContextVar, enabled):
 
 .. debug-behavior-start
 
-+ :meth:`FnOp.compute()` raise any matching-needs errors immediately;
 + :meth:`FnOp.compute()` prints out full given-inputs (not just their keys);
 + net objects print details recursively;
 + plotted SVG diagrams include style-provenance as tooltips;

graphtik/fnop.py

@@ -29,7 +29,6 @@
 from .base import (
     UNSET,
     Items,
-    MultiValueError,
     Operation,
     Plottable,
     PlotArgs,
@@ -587,20 +586,12 @@ def validate_fn_name(self):
             )
 
     def _prepare_match_inputs_error(
-        self,
-        exceptions: List[Tuple[Any, Exception]],
-        missing: List,
-        varargs_bad: List,
-        named_inputs: Mapping,
+        self, missing: List, varargs_bad: List, named_inputs: Mapping,
     ) -> ValueError:
         from .config import is_debug
 
-        errors = [
-            f"{i}. Need({n!r}) failed due to: {type(nex).__name__}({nex})"
-            for i, (n, nex) in enumerate(exceptions, 1)
-        ]
-        ner = len(exceptions) + 1
-
+        ner = 1
+        errors = []
         if missing:
             errors.append(f"{ner}. Missing compulsory needs{list(missing)}!")
             ner += 1
@@ -611,20 +602,18 @@ def _prepare_match_inputs_error(
         inputs = dict(named_inputs) if is_debug() else list(named_inputs)
         errors.append(f"+++inputs: {inputs}")
         errors.append(f"+++{self}")
-        errors.append(
-            "(tip: set GRAPHTIK_DEBUG envvar to raise immediately and/or enable DEBUG-logging)"
-        )
 
         msg = textwrap.indent("\n".join(errors), " " * 4)
-        raise MultiValueError(f"Failed preparing needs: \n{msg}", *exceptions)
+        raise ValueError(f"Failed preparing needs: \n{msg}")
 
     def _match_inputs_with_fn_needs(self, named_inputs) -> Tuple[list, list, dict]:
         positional, vararg_vals = [], []
         kwargs = {}
-        errors, missing, varargs_bad = [], [], []
+        missing, varargs_bad = [], []
         for n in self._fn_needs:
-            assert not is_sfx(n), locals()
             try:
+                ok = False
+                assert not is_sfx(n), locals()
                 if n not in named_inputs:
                     if not is_optional(n) or is_sfx(n):
                         # It means `inputs` < compulsory `needs`.
@@ -653,25 +642,15 @@ def _match_inputs_with_fn_needs(self, named_inputs) -> Tuple[list, list, dict]:
 
                 else:
                     positional.append(inp_value)
+                ok = True
+            finally:
+                if not ok:
+                    log.error(
+                        "Failed while preparing op(%s) need(%s)!", self.name, n,
+                    )
 
-            except Exception as nex:
-                from .config import is_debug
-
-                if is_debug():
-                    raise
-                log.debug(
-                    "Cannot prepare op(%s) need(%s) due to: %s",
-                    self.name,
-                    n,
-                    nex,
-                    exc_info=nex,
-                )
-                errors.append((n, nex))
-
-        if errors or missing or varargs_bad:
-            raise self._prepare_match_inputs_error(
-                errors, missing, varargs_bad, named_inputs
-            )
+        if missing or varargs_bad:
+            raise self._prepare_match_inputs_error(missing, varargs_bad, named_inputs)
 
         return positional, vararg_vals, kwargs
 

graphtik/modifier.py

@@ -595,14 +595,13 @@ def jsonp(name: str, jsonp=None) -> _Modifier:
 
         >>> results = copy_values.compute({"inputs": {"a": 1, "b": 2}})
         Traceback (most recent call last):
-        graphtik.base.MultiValueError: Failed preparing needs:
+        ValueError: Failed preparing needs:
             1. Missing compulsory needs['inputs/a'($), 'inputs/b'($)]!
             +++inputs: ['inputs']
             +++FnOp(name='copy a+b-->A+BB',
                                    needs=['inputs/a'($), 'inputs/b'($)],
                                    provides=['RESULTS/A'($), 'RESULTS/BB'($)],
                                    fn='identity_fn')
-            (tip: set GRAPHTIK_DEBUG envvar to raise immediately and/or enable DEBUG-logging)
 
         >>> results = copy_values.compute({"inputs/a": 1, "inputs/b": 2})
         >>> results
@@ -747,11 +746,10 @@ def varargs(name: str, accessor: Accessor = None, jsonp=None) -> _Modifier:
         >>> graph(a=5, b=0xBAD)
         Traceback (most recent call last):
         ...
-        graphtik.base.MultiValueError: Failed preparing needs:
+        ValueError: Failed preparing needs:
             1. Expected needs['b'(+)] to be non-str iterables!
             +++inputs: ['a', 'b']
             +++FnOp(name='enlist', needs=['a', 'b'(+)], provides=['sum'], fn='enlist')
-            (tip: set GRAPHTIK_DEBUG envvar to raise immediately and/or enable DEBUG-logging)
 
     .. varargs-mistake-start
     .. Attention::
@@ -761,14 +759,13 @@ def varargs(name: str, accessor: Accessor = None, jsonp=None) -> _Modifier:
         >>> graph(a=5, b="mistake")
         Traceback (most recent call last):
         ...
-        graphtik.base.MultiValueError: Failed preparing needs:
+        ValueError: Failed preparing needs:
             1. Expected needs['b'(+)] to be non-str iterables!
             +++inputs: ['a', 'b']
             +++FnOp(name='enlist',
                                    needs=['a', 'b'(+)],
                                    provides=['sum'],
                                    fn='enlist')
-            (tip: set GRAPHTIK_DEBUG envvar to raise immediately and/or enable DEBUG-logging)
 
     .. varargs-mistake-end
 

test/test_hierarchical.py

@@ -8,7 +8,7 @@
 
 import pytest
 
-from graphtik import NO_RESULT, MultiValueError, compose, operation, sfxed, vararg
+from graphtik import NO_RESULT, compose, operation, sfxed, vararg
 from graphtik.base import RenArgs
 from graphtik.config import solution_layered
 from graphtik.execution import task_context
@@ -60,7 +60,7 @@ def test_jsonp_and_conveyor_fn_simple():
 
     ## Ops are unaware of subdocs, Solution does.
     #
-    with pytest.raises(MultiValueError, match="Missing compulsory needs"):
+    with pytest.raises(ValueError, match="Missing compulsory needs"):
         copy_values.compute({"inputs": {"a": 1, "b": 2}})
     results = copy_values.compute({"inputs/a": 1, "inputs/b": 2})
     assert results == {"RESULTS/A": 1, "RESULTS/BB": 2}