REFACT(modif) privatize jsonp attr ...

besides being uncanny for str to have more stuff,
pandalone Pstep break :-(

Author: ankostis

graphtik/base.py

@@ -941,7 +941,7 @@ def rename_driver(ren_args: RenArgs) -> str:
             return new_name
 
         def rename_subdocs(ren_args):
-            parts = getattr(ren_args.name, "jsonp", None)
+            parts = getattr(ren_args.name, "_jsonp", None)
             if parts:  # assuming deps here have been jsonpized earlier.
                 path = "/".join(
                     rename_driver(

graphtik/jsonpointer.py

@@ -86,8 +86,8 @@ def jsonp_path(jsonpointer: str) -> List[str]:
         ['']
 
     """
-    # Optimization: modifier caches splitted parts as a "jsonp" attribute.
-    parts = getattr(jsonpointer, "jsonp", None)
+    # Optimization: modifier caches splitted parts as a "_jsonp" attribute.
+    parts = getattr(jsonpointer, "_jsonp", None)
     if parts is False:
         parts = [jsonpointer]
     elif parts is None:

graphtik/modifier.py

@@ -308,29 +308,29 @@ def _modifier(
         for client code to extend its own modifiers.
     """
     if jsonp is not None:
-        kw["jsonp"] = jsonp  # WARN: must be False or a collection for jsonp-accessors!
+        kw["_jsonp"] = jsonp  # WARN: must be False or a collection for jsonp-accessors!
     # Prevent sfx-jsonp.
     elif "/" in name and jsonp is None and (sideffected is None or sfx_list):
         from .jsonpointer import jsonp_path
 
-        kw["jsonp"] = jsonp_path(name)
+        kw["_jsonp"] = jsonp_path(name)
     # Don't override user's accessor.
     #
-    if not accessor and kw.get("jsonp"):
+    if not accessor and kw.get("_jsonp"):
         accessor = JsonpAccessor()
 
     args = (name, keyword, optional, accessor, sideffected, sfx_list)
     formats = _match_modifier_args(*args)
     if not formats:
-        if kw.get("jsonp") is not None:
+        if kw.get("_jsonp") is not None:
             # Just jsonp given.
             assert not accessor and (optional, accessor, sideffected, sfx_list) == (
                 None,
                 None,
                 None,
                 (),
             ), locals()
-            return _Modifier(name, name, f"jsonp", *args[1:], jsonp=jsonp)
+            return _Modifier(name, name, "jsonp", *args[1:], jsonp=jsonp)
 
         # Make a plain string instead.
         return str(name)
@@ -370,7 +370,7 @@ def modifier_withset(
                 k: v
                 for k, v in vars(dep).items()
                 # Regenerate cached, truthy-only, jsnop-parts.
-                if k != "jsonp" or not v
+                if k != "_jsonp" or not v
             },
             **{k: v for k, v in locals().items() if v is not ...},
             **kw,
@@ -1049,7 +1049,7 @@ def is_varargish(dep) -> bool:
 
 def get_jsonp(dep) -> Union[List[str], None]:
     """Check if the dependency is :term:`json pointer path` and return steps."""
-    return getattr(dep, "jsonp", None)
+    return getattr(dep, "_jsonp", None)
 
 
 def is_sfx(dep) -> Optional[str]:

test/test_jsonpointer.py

@@ -69,12 +69,12 @@ class C(str):
 
     p = C("a/b")
     assert jsonp_path(p) == ["a", "b"]
-    p.jsonp = False
+    p._jsonp = False
     assert jsonp_path(p) == [p]
-    assert p.jsonp == False
-    p.jsonp = None
+    assert p._jsonp == False
+    p._jsonp = None
     assert jsonp_path(p) == ["a", "b"]
-    assert p.jsonp == None
+    assert p._jsonp == None
 
 
 @pytest.mark.parametrize(

test/test_modifier.py

@@ -252,10 +252,10 @@ def test_modifs_rename_fn(mod, exp, ser_method):
         # Check not just(!) `_repr` has changed.
         assert got.sideffected != dep.sideffected
 
-    if getattr(dep, "jsonp", None):
-        assert got.jsonp != dep.jsonp
-        assert got.jsonp == jsonp_path(got)
-        assert got.jsonp == jsonp_path(str(got))
+    if getattr(dep, "_jsonp", None):
+        assert got._jsonp != dep._jsonp
+        assert got._jsonp == jsonp_path(got)
+        assert got._jsonp == jsonp_path(str(got))
 
 
 @pytest.mark.parametrize(