Skip to content

Commit 6b401b2

Browse files
committed
DROP(plot): -splines=ortho crashes with some shapes ...
See https://gitlab.com/graphviz/graphviz/issues/1408 + doc: explain in docs how to re-enables (x2 ways).
1 parent c485335 commit 6b401b2

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

graphtik/base.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,9 @@ def plot(
491491
- ``_no_plot``: nodes and/or edges skipped from plotting
492492
(see *"Examples:"* section, below)
493493
494-
- "public" attributes: reaching `Graphviz`_ as-is.
494+
- "public" attributes: reaching `Graphviz`_ as-is, e.g.
495+
to set ``spline -> ortho`` on the graph attributes
496+
(this can also be achieved by modified :term:`plot styles`).
495497
496498
.. Note::
497499
@@ -579,9 +581,9 @@ def plot(
579581
green-dotted arrows
580582
execution steps labeled in succession
581583
582-
583584
To generate the **legend**, see :func:`.legend()`.
584585
586+
585587
**Examples:**
586588
587589
>>> from graphtik import compose, operation
@@ -604,10 +606,11 @@ def plot(
604606
digraph netop {
605607
fontname=italic;
606608
label=<netop>;
607-
splines=ortho;
608609
<a> [fillcolor=wheat, shape=invhouse, style=filled, tooltip="(int) 1"];
609610
...
610611
612+
.. TODO: move advanced plot examples from API --> tutorial page
613+
611614
You may use the :attr:`PlotArgs.graph` overlay to skip certain nodes (or edges)
612615
from the plots:
613616

graphtik/plot.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -360,9 +360,11 @@ class Style:
360360
kw_graph = {
361361
"graph_type": "digraph",
362362
"fontname": "italic",
363-
# Whether to plot `curved/polyline edges
364-
# <https://graphviz.gitlab.io/_pages/doc/info/attrs.html#d:splines>`_
365-
"splines": "ortho",
363+
## Whether to plot `curved/polyline edges
364+
# <https://graphviz.gitlab.io/_pages/doc/info/attrs.html#d:splines>`_
365+
# BUT disabled due to crashes:
366+
# https://gitlab.com/graphviz/graphviz/issues/1408
367+
#"splines": "ortho",
366368
}
367369
#: styles per plot-type
368370
kw_pottable_type = {

test/test_plot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,6 @@ def test_node_dot_str0(dot_str_pipeline):
433433
digraph graph_ {
434434
fontname=italic;
435435
label=<graph>;
436-
splines=ortho;
437436
<edge> [shape=invhouse];
438437
<digraph&#58; strict> [shape=invhouse];
439438
<node> [label=<<TABLE CELLBORDER="0" CELLSPACING="0" STYLE="rounded">
@@ -482,6 +481,7 @@ def test_node_dot_str1(dot_str_pipeline, monkeypatch):
482481
overlay = nx.DiGraph()
483482
hidden_op = dot_str_pipeline.net.find_op_by_name("node")
484483
overlay.add_node(hidden_op, _no_plot=True)
484+
overlay.graph["splines"] = "ortho"
485485

486486
sol = dot_str_pipeline.compute({"edge": 1, "digraph: strict": 2})
487487
dot_str = str(sol.plot(graph=overlay))

0 commit comments

Comments
 (0)