Skip to content

Commit ae05e92

Browse files
committed
typo(test): overriden-->overriDDen
1 parent 6ab825f commit ae05e92

File tree

2 files changed

+25
-26
lines changed

2 files changed

+25
-26
lines changed

CHANGES.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ TODO
77
See also :gg:`1`.
88

99
+ [ ] use a "start-node" to insert input-values in solution
10-
+ [ ] typo(test): overriden-->overriDDen
1110
+ [ ] support functions with ``*args`` and ``**kwargs``.
1211

1312

test/test_graphtik.py

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -350,17 +350,17 @@ def test_pruning_raises_for_bad_output():
350350
def test_pruning_not_overrides_given_intermediate():
351351
# Test #25: v1.2.4 overwrites intermediate data when no output asked
352352
pipeline = compose(name="pipeline")(
353-
operation(name="not run", needs=["a"], provides=["overriden"])(scream),
354-
operation(name="op", needs=["overriden", "c"], provides=["asked"])(add),
353+
operation(name="not run", needs=["a"], provides=["overidden"])(scream),
354+
operation(name="op", needs=["overidden", "c"], provides=["asked"])(add),
355355
)
356356

357-
inputs = {"a": 5, "overriden": 1, "c": 2}
358-
exp = {"a": 5, "overriden": 1, "c": 2, "asked": 3}
357+
inputs = {"a": 5, "overidden": 1, "c": 2}
358+
exp = {"a": 5, "overidden": 1, "c": 2, "asked": 3}
359359
# v1.2.4.ok
360360
assert pipeline(inputs, ["asked"]) == filtdict(exp, "asked")
361361
# FAILs
362-
# - on v1.2.4 with (overriden, asked): = (5, 7) instead of (1, 3)
363-
# - on #18(unsatisfied) + #23(ordered-sets) with (overriden, asked) = (5, 7) instead of (1, 3)
362+
# - on v1.2.4 with (overidden, asked): = (5, 7) instead of (1, 3)
363+
# - on #18(unsatisfied) + #23(ordered-sets) with (overidden, asked) = (5, 7) instead of (1, 3)
364364
# FIXED on #26
365365
assert pipeline(inputs) == exp
366366

@@ -394,27 +394,27 @@ def test_pruning_multiouts_not_override_intermediates1():
394394
# Test #25: v.1.2.4 overwrites intermediate data when a previous operation
395395
# must run for its other outputs (outputs asked or not)
396396
pipeline = compose(name="graph")(
397-
operation(name="must run", needs=["a"], provides=["overriden", "calced"])(
397+
operation(name="must run", needs=["a"], provides=["overidden", "calced"])(
398398
lambda x: (x, 2 * x)
399399
),
400-
operation(name="add", needs=["overriden", "calced"], provides=["asked"])(add),
400+
operation(name="add", needs=["overidden", "calced"], provides=["asked"])(add),
401401
)
402402

403-
inputs = {"a": 5, "overriden": 1, "c": 2}
404-
exp = {"a": 5, "overriden": 1, "calced": 10, "asked": 11}
403+
inputs = {"a": 5, "overidden": 1, "c": 2}
404+
exp = {"a": 5, "overidden": 1, "calced": 10, "asked": 11}
405405
# FAILs
406-
# - on v1.2.4 with (overriden, asked) = (5, 15) instead of (1, 11)
406+
# - on v1.2.4 with (overidden, asked) = (5, 15) instead of (1, 11)
407407
# - on #18(unsatisfied) + #23(ordered-sets) like v1.2.4.
408408
# FIXED on #26
409-
assert pipeline({"a": 5, "overriden": 1}) == exp
409+
assert pipeline({"a": 5, "overidden": 1}) == exp
410410
# FAILs
411411
# - on v1.2.4 with KeyError: 'e',
412412
# - on #18(unsatisfied) + #23(ordered-sets) with empty result.
413413
# FIXED on #26
414414
assert pipeline(inputs, ["asked"]) == filtdict(exp, "asked")
415-
# Plan must contain "overriden" step twice, for pin & evict.
415+
# Plan must contain "overidden" step twice, for pin & evict.
416416
# Plot it to see, or check https://github.com/huyng/graphtik/pull/1#discussion_r334226396.
417-
datasteps = [s for s in pipeline.last_plan.steps if s == "overriden"]
417+
datasteps = [s for s in pipeline.last_plan.steps if s == "overidden"]
418418
assert len(datasteps) == 2
419419
assert isinstance(datasteps[0], network._PinInstruction)
420420
assert isinstance(datasteps[1], network._EvictInstruction)
@@ -423,18 +423,18 @@ def test_pruning_multiouts_not_override_intermediates1():
423423
#
424424
overwrites = {}
425425
pipeline.set_overwrites_collector(overwrites)
426-
assert pipeline({"a": 5, "overriden": 1}) == exp
427-
assert overwrites == {"overriden": 5}
426+
assert pipeline({"a": 5, "overidden": 1}) == exp
427+
assert overwrites == {"overidden": 5}
428428

429429
overwrites = {}
430430
pipeline.set_overwrites_collector(overwrites)
431431
assert pipeline(inputs, ["asked"]) == filtdict(exp, "asked")
432-
assert overwrites == {"overriden": 5}
432+
assert overwrites == {"overidden": 5}
433433

434434
## Test parallel
435435
#
436436
pipeline.set_execution_method("parallel")
437-
assert pipeline({"a": 5, "overriden": 1}) == exp
437+
assert pipeline({"a": 5, "overidden": 1}) == exp
438438
assert pipeline(inputs, ["asked"]) == filtdict(exp, "asked")
439439

440440

@@ -449,17 +449,17 @@ def test_pruning_multiouts_not_override_intermediates2():
449449
# SPURIOUS FAILS in < PY3.6 due to unordered dicts,
450450
# eg https://travis-ci.org/ankostis/graphtik/jobs/594813119
451451
pipeline = compose(name="pipeline")(
452-
operation(name="must run", needs=["a"], provides=["overriden", "e"])(
452+
operation(name="must run", needs=["a"], provides=["overidden", "e"])(
453453
lambda x: (x, 2 * x)
454454
),
455-
operation(name="op1", needs=["overriden", "c"], provides=["d"])(add),
455+
operation(name="op1", needs=["overidden", "c"], provides=["d"])(add),
456456
operation(name="op2", needs=["d", "e"], provides=["asked"])(mul),
457457
)
458458

459-
inputs = {"a": 5, "overriden": 1, "c": 2}
460-
exp = {"a": 5, "overriden": 1, "c": 2, "d": 3, "e": 10, "asked": 30}
459+
inputs = {"a": 5, "overidden": 1, "c": 2}
460+
exp = {"a": 5, "overidden": 1, "c": 2, "d": 3, "e": 10, "asked": 30}
461461
# FAILs
462-
# - on v1.2.4 with (overriden, asked) = (5, 70) instead of (1, 13)
462+
# - on v1.2.4 with (overidden, asked) = (5, 70) instead of (1, 13)
463463
# - on #18(unsatisfied) + #23(ordered-sets) like v1.2.4.
464464
# FIXED on #26
465465
assert pipeline(inputs) == exp
@@ -474,12 +474,12 @@ def test_pruning_multiouts_not_override_intermediates2():
474474
overwrites = {}
475475
pipeline.set_overwrites_collector(overwrites)
476476
assert pipeline(inputs) == exp
477-
assert overwrites == {"overriden": 5}
477+
assert overwrites == {"overidden": 5}
478478

479479
overwrites = {}
480480
pipeline.set_overwrites_collector(overwrites)
481481
assert pipeline(inputs, ["asked"]) == filtdict(exp, "asked")
482-
assert overwrites == {"overriden": 5}
482+
assert overwrites == {"overidden": 5}
483483

484484
## Test parallel
485485
#

0 commit comments

Comments
 (0)