Skip to content

Commit e7f55d3

Browse files
committed
refact(TCs) skip xs xfail for py3.6 string asserts
1 parent 447d948 commit e7f55d3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/test_plot.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ def dot_str_pipeline():
547547
)
548548

549549

550-
@pytest.mark.xfail(
550+
@pytest.mark.skipif(
551551
sys.version_info < (3, 7), reason="PY3.6- have different docstrings for builtins."
552552
)
553553
def test_node_dot_str0(dot_str_pipeline):
@@ -605,7 +605,7 @@ def test_node_dot_str0(dot_str_pipeline):
605605
assert _striplines(dot_str) == _striplines(exp)
606606

607607

608-
@pytest.mark.xfail(
608+
@pytest.mark.skipif(
609609
sys.version_info < (3, 7), reason="PY3.6 - has different docstrings for builtins."
610610
)
611611
def test_node_dot_str1(dot_str_pipeline, monkeypatch):

test/test_sideffects.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ def finalize_prices(order: DataFrame) -> Tuple[DataFrame, float]:
333333
return compose("process order", *ops, parallel=exemethod)
334334

335335

336-
@pytest.mark.xfail(
336+
@pytest.mark.skipif(
337337
sys.version_info < (3, 7),
338338
reason="Pickling function typing of return annotations fails.",
339339
)
@@ -380,7 +380,7 @@ def test_sideffecteds_ok(calc_prices_pipeline):
380380
assert re.search(r'(?s)>vat owed<.+tooltip=".*\(evicted\)"', dot)
381381

382382

383-
@pytest.mark.xfail(
383+
@pytest.mark.skipif(
384384
sys.version_info < (3, 7),
385385
reason="Pickling function typing of return annotations fails.",
386386
)

0 commit comments

Comments
 (0)