refact(op): shrink repr() by removing "name="

Author: ankostis

docs/source/composition.rst

@@ -135,7 +135,7 @@ We can merge ``graphop`` and ``another_graph`` like so, avoiding a redundant ``m
 
    >>> merged_graph = compose("merged_graph", graphop, another_graph, merge=True)
    >>> print(merged_graph)
-   NetworkOperation(name='merged_graph',
+   NetworkOperation('merged_graph',
                     needs=['a', 'b', 'c'],
                     provides=['ab', 'a_minus_ab', 'abs_a_minus_ab_cubed', 'cab'])
 

graphtik/modifiers.py

@@ -33,7 +33,7 @@ class optional(str):
         ...     operation(name='myadd', needs=['a', 'b', optional('c')], provides='sum')(myadd)
         ... )
         >>> graph
-        NetworkOperation(name='mygraph',
+        NetworkOperation('mygraph',
                          needs=['a', 'b', optional('c')],
                          provides=['sum'])
 
@@ -70,7 +70,7 @@ class vararg(optional):
         ...     provides='sum')(addall)
         ... )
         >>> graph
-        NetworkOperation(name='mygraph',
+        NetworkOperation('mygraph',
                          needs=['a', optional('b'), optional('c')],
                          provides=['sum'])
 
@@ -138,7 +138,7 @@ class sideffect(str):
         ...         provides=[sideffect('df.sum')])(addcolumns)
         ... )
         >>> graph
-        NetworkOperation(name='mygraph', needs=['df', 'sideffect(df.b)'],
+        NetworkOperation('mygraph', needs=['df', 'sideffect(df.b)'],
                          provides=['sideffect(df.sum)'])
 
         >>> df = pd.DataFrame({'a': [5, 0], 'b': [2, 1]})   # doctest: +SKIP

graphtik/op.py

@@ -105,7 +105,7 @@ def __repr__(self):
         clsname = type(self).__name__
         needs = aslist(self.needs, "needs")
         provides = aslist(self.provides, "provides")
-        return f"{clsname}(name={self.name!r}, needs={needs!r}, provides={provides!r})"
+        return f"{clsname}({self.name!r}, needs={needs!r}, provides={provides!r})"
 
 
 class FunctionalOperation(Operation):

test/test_graphtik.py

@@ -237,7 +237,7 @@ def test_network_simple_merge():
 
     assert (
         repr(net3)
-        == "NetworkOperation(name='merged', needs=['c', 'd', 'e', 'f'], provides=['sum1', 'sum2', 'sum3', 'a', 'b'])"
+        == "NetworkOperation('merged', needs=['c', 'd', 'e', 'f'], provides=['sum1', 'sum2', 'sum3', 'a', 'b'])"
     )
 
 
@@ -254,7 +254,7 @@ def test_network_deep_merge():
     assert net1(a=1, b=2, c=4) == exp
     assert (
         repr(net1)
-        == "NetworkOperation(name='my network 1', needs=[optional('a'), 'b', 'c'], provides=['sum1', 'sum2', 'sum3'])"
+        == "NetworkOperation('my network 1', needs=[optional('a'), 'b', 'c'], provides=['sum1', 'sum2', 'sum3'])"
     )
 
     sum_op4 = operation(name="sum_op1", needs=[vararg("a"), "b"], provides="sum1")(
@@ -266,7 +266,7 @@ def test_network_deep_merge():
     assert net2(**{"a": 1, "b": 2}) == exp
     assert (
         repr(net2)
-        == "NetworkOperation(name='my network 2', needs=[optional('a'), 'b'], provides=['sum1', 'sum2'])"
+        == "NetworkOperation('my network 2', needs=[optional('a'), 'b'], provides=['sum1', 'sum2'])"
     )
 
     net3 = compose("merged", net1, net2, merge=True)
@@ -275,7 +275,7 @@ def test_network_deep_merge():
 
     assert (
         repr(net3)
-        == "NetworkOperation(name='merged', needs=[optional('a'), 'b', 'c'], provides=['sum2', 'sum1', 'sum3'])"
+        == "NetworkOperation('merged', needs=[optional('a'), 'b', 'c'], provides=['sum2', 'sum1', 'sum3'])"
     )
 
     ## Reverse ops, change results and `needs` optionality.
@@ -286,7 +286,7 @@ def test_network_deep_merge():
 
     assert (
         repr(net3)
-        == "NetworkOperation(name='merged', needs=[optional('a'), 'b', 'c'], provides=['sum1', 'sum2', 'sum3'])"
+        == "NetworkOperation('merged', needs=[optional('a'), 'b', 'c'], provides=['sum1', 'sum2', 'sum3'])"
     )
 
 
@@ -311,7 +311,7 @@ def test_network_merge_in_doctests():
 
     assert (
         repr(merged_graph)
-        == "NetworkOperation(name='merged_graph', needs=['a', 'b', 'c'], provides=['ab', 'a_minus_ab', 'abs_a_minus_ab_cubed', 'cab'])"
+        == "NetworkOperation('merged_graph', needs=['a', 'b', 'c'], provides=['ab', 'a_minus_ab', 'abs_a_minus_ab_cubed', 'cab'])"
     )
 
 
@@ -754,40 +754,40 @@ def add(a=0, b=0):
     netop = compose("t", *ops)
     assert (
         repr(netop)
-        == f"NetworkOperation(name='t', needs=['a', optional('bb')], provides=[{provs}])"
+        == f"NetworkOperation('t', needs=['a', optional('bb')], provides=[{provs}])"
     )
 
     ## Narrow by `needs`
     #
     netop = compose("t", *ops, needs=["a"])
-    assert repr(netop) == f"NetworkOperation(name='t', needs=['a'], provides=[{provs}])"
+    assert repr(netop) == f"NetworkOperation('t', needs=['a'], provides=[{provs}])"
 
     netop = compose("t", *ops, needs=["bb"])
     assert (
         repr(netop)
-        == "NetworkOperation(name='t', needs=[optional('bb')], provides=['sum1'])"
+        == "NetworkOperation('t', needs=[optional('bb')], provides=['sum1'])"
     )
 
     ## Narrow by `provides`
     #
     netop = compose("t", *ops, provides="sum1")
     assert (
         repr(netop)
-        == "NetworkOperation(name='t', needs=[optional('a'), optional('bb')], provides=['sum1'])"
+        == "NetworkOperation('t', needs=[optional('a'), optional('bb')], provides=['sum1'])"
     )
 
     netop = compose("t", *ops, provides=["sum2"])
     assert (
         repr(netop)
-        == "NetworkOperation(name='t', needs=['a', optional('bb')], provides=['sum2'])"
+        == "NetworkOperation('t', needs=['a', optional('bb')], provides=['sum2'])"
     )
 
     ## Narrow by BOTH
     #
     netop = compose("t", *ops, needs="a", provides=["sum1"])
     assert (
         repr(netop)
-        == "NetworkOperation(name='t', needs=[optional('a')], provides=['sum1'])"
+        == "NetworkOperation('t', needs=[optional('a')], provides=['sum1'])"
     )
 
     with pytest.raises(ValueError, match="Impossible outputs:"):
@@ -796,7 +796,7 @@ def add(a=0, b=0):
     ## Narrow by unknown needs
     #
     netop = compose("t", *ops, needs="BAD")
-    assert repr(netop) == "NetworkOperation(name='t', needs=[], provides=['sum1'])"
+    assert repr(netop) == "NetworkOperation('t', needs=[], provides=['sum1'])"
 
 
 # Function without return value.