Update idempotency flags / reasons in operation tests.

Author: Fizzadar

tests/operations/dnf.rpm/add.json

@@ -12,6 +12,5 @@
     },
     "commands": [
         "rpm -i something.rpm"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/dnf.rpm/add_existing_upgrade.json

@@ -11,6 +11,5 @@
             }
         }
     },
-    "commands": ["rpm -i something.rpm"],
-    "idempotent": false
+    "commands": ["rpm -i something.rpm"]
 }

tests/operations/dnf.rpm/add_url.json

@@ -16,5 +16,9 @@
         "curl -sSLf https://something.rpm -o _tempfile_.rpm",
         "rpm -q `rpm -qp _tempfile_.rpm` 2> /dev/null || rpm -i _tempfile_.rpm"
     ],
-    "idempotent": false
+    "second_output_commands": [
+        "rpm -q `rpm -qp _tempfile_.rpm` 2> /dev/null || rpm -i _tempfile_.rpm"
+    ],
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "packages that require downloads cannot be checked for presence during fact gathering"
 }

tests/operations/dnf.rpm/remove.json

@@ -16,6 +16,5 @@
     },
     "commands": [
         "dnf remove -y something"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/files.download/download_cache_time.json

@@ -15,5 +15,6 @@
             "command=curl": "yes"
         }
     },
-    "commands": []
+    "commands": [],
+    "noop_description": "file /home/myfile has already been downloaded"
 }

tests/operations/files.download/download_cache_time_needs_refresh.json

@@ -17,6 +17,5 @@
     },
     "commands": [
         "curl -sSLf http://myfile -o /home/myfile"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/files.sync/sync_exclude_multiple.json

@@ -92,6 +92,5 @@
             "/home/somedir/underthat/another_file.txt"
         ],
         "chmod 644 /home/somedir/underthat/another_file.txt"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/files.sync/sync_no_destination_exist.json

@@ -50,6 +50,5 @@
             "/home/somedir/underthat/another-file.txt"
         ],
         "chmod 644 /home/somedir/underthat/another-file.txt"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/git.bare_repo/delete.json

@@ -10,6 +10,5 @@
     },
     "commands": [
         "rm -rf /home/mybarerepo.git"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/git.repo/branch_pull.json

@@ -19,5 +19,9 @@
         "cd /home/myrepo && git checkout mybranch",
         "cd /home/myrepo && git pull"
     ],
-    "idempotent": false
+    "second_output_commands": [
+        "cd /home/myrepo && git pull"
+    ],
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "git branch pull always executed"
 }