Skip to content

Update scipy to 1.17.0 #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jan-janssen wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update scipy to 1.17.0 #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a57e120
Update pyproject.toml
jan-janssen Jan 25, 2026
575c636
Update environment.yml
jan-janssen Jan 25, 2026
93e2148
Update environment-docs.yml
jan-janssen Jan 25, 2026
d0f1b69
Update environment.yml
jan-janssen Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci_support/environment-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
- ase =3.27.0
- coverage
- numpy =2.3.5
- scipy =1.16.3
- scipy =1.17.0
- spglib =2.7.0
- phonopy =2.47.1
- structuretoolkit =0.0.39
Expand Down
2 changes: 1 addition & 1 deletion .ci_support/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
- pandas =2.3.3
- phonopy =2.47.1
- requests =2.32.5
- scipy =1.16.3
- scipy =1.17.0
- seekpath =2.2.0
- spglib =2.7.0
- structuretoolkit =0.0.39
Expand Down
2 changes: 1 addition & 1 deletion binder/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
dependencies:
- ase =3.27.0
- numpy =2.3.5
- scipy =1.16.3
- scipy =1.17.0
- spglib =2.7.0
- phonopy =2.47.1
- structuretoolkit =0.0.39
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ classifiers = [
dependencies = [
"ase==3.27.0",
"numpy==2.3.5",
"scipy==1.16.3",
"scipy==1.17.0",
"spglib==2.7.0",
]
Comment on lines 27 to 32
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

scipy 1.17.0 PyPI release supported python versions

💡 Result:

SciPy 1.17.0 on PyPI supports Python 3.11, 3.12, 3.13, and 3.14 (PyPI metadata: Requires-Python: >=3.11; classifiers list 3.11–3.14; wheels are published for cp311–cp314). [1]

🌐 Web query:

scipy 1.17.0 numpy compatibility requirements

💡 Result:

SciPy 1.17.0 requires NumPy 1.26.4 or newer (i.e., numpy>=1.26.4). [1][2]

SciPy 1.17.0 requires Python ≥3.11, incompatible with declared Python 3.9–3.10 support.

SciPy 1.17.0 drops support for Python 3.9 and 3.10 (requires Python ≥3.11). The project claims to support Python 3.9–3.14, making this dependency unpinnable for Python 3.9 and 3.10. Either update the minimum Python version to 3.11 in project metadata or downgrade SciPy to a version supporting Python 3.9+. NumPy 2.3.5 is compatible with SciPy 1.17.0.

🤖 Prompt for AI Agents 
In `@pyproject.toml` around lines 27 - 32, The pyproject dependency pin
"scipy==1.17.0" in the dependencies list is incompatible with the declared
Python support (3.9–3.10); either change the project metadata python_requires to
require Python >=3.11 (update python_requires in pyproject.toml) or downgrade
the SciPy pin to a release that supports 3.9/3.10 (e.g., replace "scipy==1.17.0"
with a 1.10.x/1.9.x version) so the "dependencies" list and python_requires are
consistent.

dynamic = ["version"]
Expand Down
Loading