Actually use the new function in the convergence checks

Author: sudarsan-surendralal

pyiron_atomistics/sphinx/base.py

@@ -1379,8 +1379,16 @@ def collect_output(self, force_update=False):
 
     def convergence_check(self):
         """
-        Checks if job has converged according to given cutoffs.
+        Checks for electronic and ionic convergence according to the user specified tolerance
+
+        Returns:
+
+            bool: True if converged
+
         """
+        # Checks if sufficient empty states are present
+        if not self.nbands_convergence_check():
+            return False
         if (
             self._generic_input["calc_mode"] == "minimize"
             and self._output_parser._parse_dict["scf_convergence"][-1]

pyiron_atomistics/vasp/base.py

@@ -404,6 +404,19 @@ def collect_output(self):
             )
 
     def convergence_check(self):
+        """
+        Checks for electronic and ionic convergence according to the user specified tolerance
+
+        Returns:
+
+            bool: True if converged
+
+        """
+        # Checks if sufficient empty states are present
+        if not self.nbands_convergence_check():
+            return False
+        if not self.nbands_convergence_check():
+            return False
         if "IBRION" in self["input/incar/data_dict"]["Parameter"]:
             ind = self["input/incar/data_dict"]["Parameter"].index("IBRION")
             ibrion = int(self["input/incar/data_dict"]["Value"][ind])