Skip to content

Commit ebcb4b4

Browse files
committed
Make error message more specific
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
1 parent c9ae3d9 commit ebcb4b4

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

pyiron_snippets/versions.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,10 +216,17 @@ def get_qualname(obj: Any) -> str | None:
216216
)
217217
)
218218
)
219+
qualname_source = "(`obj.__qualname__` > `obj.__name__` > type(obj).__qualname__`)"
219220
if not isinstance(qualname, str):
220-
raise TypeError(f"Expected a string __qualname__, but {obj} had {qualname}.")
221+
raise TypeError(
222+
f"Expected a string qualname source {qualname_source}, but {obj} had "
223+
f"'{qualname}'."
224+
)
221225
if len(qualname) == 0:
222-
raise ValueError(f"Expected a non-empty qualname string for {obj}.")
226+
raise ValueError(
227+
f"Expected a _non-empty_ string as the qualname source {qualname_source} "
228+
f"for {obj}."
229+
)
223230
return qualname
224231

225232

tests/unit/test_versions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def test_empty_qualname_raises(self):
193193
Anonymous = type("", (), {})
194194
with self.assertRaises(ValueError) as ctx:
195195
get_qualname(Anonymous)
196-
self.assertIn("Expected a non-empty", str(ctx.exception))
196+
self.assertIn("Expected a _non-empty_", str(ctx.exception))
197197

198198
def test_name_used_when_qualname_absent(self) -> None:
199199
"""Simulates the ufunc pattern: __name__ present, __qualname__ absent."""

0 commit comments

Comments
 (0)