Skip to content

Commit 4c429e6

Browse files
authored
Merge branch 'pyjanitor-devs:dev' into ci/testing-env
2 parents 4d26689 + 78d4297 commit 4c429e6

File tree

3 files changed

+22
-20
lines changed

3 files changed

+22
-20
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
- [BUG] Force `math.softmax` returning `Series`. PR #1139 @Zeroto521
1919
- [INF] Set independent environment for building documentation. PR #1141 @Zeroto521
2020
- [DOC] Add local documentation preview via github action artifact. PR #1149 @Zeroto521
21-
- [ENH] Enabel `encode_categorical` handle 2 (or more ) dimensions array. PR #1153 @Zeroto521
21+
- [ENH] Enable `encode_categorical` handle 2 (or more ) dimensions array. PR #1153 @Zeroto521
2222

2323
## [v0.23.1] - 2022-05-03
2424

tests/functions/test_pivot_longer.py

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -663,8 +663,9 @@ def test_names_pattern_str(test_df):
663663
column_names="*_*",
664664
names_to=["set", ".value"],
665665
names_pattern="(.+)_(.+)",
666-
sort_by_appearance=True,
666+
sort_by_appearance=False,
667667
)
668+
result = result.sort_values(result.columns.tolist(), ignore_index=True)
668669

669670
actual = test_df.copy()
670671
actual.columns = actual.columns.str.split("_").str[::-1].str.join("_")
@@ -680,6 +681,7 @@ def test_names_pattern_str(test_df):
680681
.reset_index("set")
681682
.reset_index(drop=True)
682683
)
684+
actual = actual.sort_values(actual.columns.tolist(), ignore_index=True)
683685

684686
assert_frame_equal(result, actual)
685687

@@ -706,6 +708,9 @@ def test_names_sep(test_df):
706708
.reset_index(drop=True)
707709
)
708710

711+
result = result.sort_values(result.columns.tolist(), ignore_index=True)
712+
actual = actual.sort_values(actual.columns.tolist(), ignore_index=True)
713+
709714
assert_frame_equal(result, actual)
710715

711716

@@ -1188,18 +1193,12 @@ def test_names_transform_numeric():
11881193
}
11891194
)
11901195

1191-
expected = (
1192-
df.pivot_longer(
1193-
index="A",
1194-
names_to=(".value", "colname"),
1195-
names_sep="_",
1196-
names_transform=float,
1197-
)
1198-
.sort_values(
1199-
["A", "colname", "result", "treatment"], ignore_index=True
1200-
)
1201-
.loc[:, ["A", "colname", "result", "treatment"]]
1202-
)
1196+
result = df.pivot_longer(
1197+
index="A",
1198+
names_to=(".value", "colname"),
1199+
names_sep="_",
1200+
names_transform=float,
1201+
).loc[:, ["A", "colname", "result", "treatment"]]
12031202

12041203
actual = pd.wide_to_long(
12051204
df,
@@ -1210,7 +1209,10 @@ def test_names_transform_numeric():
12101209
sep="_",
12111210
).reset_index()
12121211

1213-
assert_frame_equal(actual, expected)
1212+
result = result.sort_values(result.columns.tolist(), ignore_index=True)
1213+
actual = actual.sort_values(actual.columns.tolist(), ignore_index=True)
1214+
1215+
assert_frame_equal(actual, result)
12141216

12151217

12161218
def test_duplicated_columns():

tests/utils/test__select_column.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pandas as pd
66
import pytest
77

8-
from pandas.testing import assert_index_equal
8+
from pandas.testing import assert_index_equal, assert_frame_equal
99
from janitor.functions.utils import _select_column_names, patterns
1010

1111

@@ -165,10 +165,10 @@ def test_strings_dates_range(df_dates):
165165
def test_unsorted_dates(df_dates):
166166
"""Test output if the dates are unsorted, and a string is passed."""
167167
df_dates = df_dates.iloc[:, [10, 4, 7, 2, 1, 3, 5, 6, 8, 9, 11, 0]]
168-
assert_index_equal(
169-
df_dates.loc[:, ["2011-01-31"]].columns,
170-
_select_column_names("2011-01-31", df_dates),
171-
)
168+
expected = df_dates.loc[:, ["2011-01-31"]]
169+
actual = _select_column_names("2011-01-31", df_dates)
170+
actual = df_dates.loc[:, actual]
171+
assert_frame_equal(expected, actual)
172172

173173

174174
def test_regex(df1):

0 commit comments

Comments
 (0)