From b29779f7012fd46680dc68e4f8e7098255b7717b Mon Sep 17 00:00:00 2001 From: Zero Date: Fri, 19 Aug 2022 14:26:45 +0800 Subject: [PATCH 1/5] correct file name, remove duplicate `_` --- tests/utils/{test__select_column.py => test_select_column.py} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tests/utils/{test__select_column.py => test_select_column.py} (100%) diff --git a/tests/utils/test__select_column.py b/tests/utils/test_select_column.py similarity index 100% rename from tests/utils/test__select_column.py rename to tests/utils/test_select_column.py From b6b39d9f0eeae8a72d4ee9dac81be3671b8da400 Mon Sep 17 00:00:00 2001 From: Zero Date: Fri, 19 Aug 2022 14:37:09 +0800 Subject: [PATCH 2/5] The return type is `list` --- tests/utils/test_select_column.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/utils/test_select_column.py b/tests/utils/test_select_column.py index a6099d085..553bca684 100644 --- a/tests/utils/test_select_column.py +++ b/tests/utils/test_select_column.py @@ -165,10 +165,9 @@ def test_strings_dates_range(df_dates): def test_unsorted_dates(df_dates): """Test output if the dates are unsorted, and a string is passed.""" df_dates = df_dates.iloc[:, [10, 4, 7, 2, 1, 3, 5, 6, 8, 9, 11, 0]] - assert_index_equal( - df_dates.loc[:, ["2011-01-31"]].columns, - _select_column_names("2011-01-31", df_dates), - ) + result = _select_column_names("2011-01-31", df_dates) + + assert result == df_dates[["2011-01-31"]].columns.tolist() def test_regex(df1): From ad9725af56b8949db5baeac6d9ff06c26aa630de Mon Sep 17 00:00:00 2001 From: Zero Date: Fri, 19 Aug 2022 14:44:20 +0800 Subject: [PATCH 3/5] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 374442297..dfa1df915 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ - [BUG] Force `math.softmax` returning `Series`. PR #1139 @Zeroto521 - [INF] Set independent environment for building documentation. PR #1141 @Zeroto521 - [DOC] Add local documentation preview via github action artifact. PR #1149 @Zeroto521 +- [TST] Rename `tests/utils/test_select_column.py` → `tests/utils/test_select_column.py` and update `functions/utils.py::_select_column_names` testcase. PR #1152 @Zeroto521 ## [v0.23.1] - 2022-05-03 From fc871adb76edfcc5b1668be33909ac21de6abecf Mon Sep 17 00:00:00 2001 From: Zero Date: Sat, 20 Aug 2022 08:30:53 +0800 Subject: [PATCH 4/5] Revert "correct file name, remove duplicate `_`" This reverts commit b29779f7012fd46680dc68e4f8e7098255b7717b. --- tests/utils/{test_select_column.py => test__select_column.py} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tests/utils/{test_select_column.py => test__select_column.py} (100%) diff --git a/tests/utils/test_select_column.py b/tests/utils/test__select_column.py similarity index 100% rename from tests/utils/test_select_column.py rename to tests/utils/test__select_column.py From f153005313e6e57b7bead3715aae7b931eac858a Mon Sep 17 00:00:00 2001 From: Zero Date: Sat, 20 Aug 2022 08:32:20 +0800 Subject: [PATCH 5/5] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dfa1df915..d21eba457 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,7 @@ - [BUG] Force `math.softmax` returning `Series`. PR #1139 @Zeroto521 - [INF] Set independent environment for building documentation. PR #1141 @Zeroto521 - [DOC] Add local documentation preview via github action artifact. PR #1149 @Zeroto521 -- [TST] Rename `tests/utils/test_select_column.py` → `tests/utils/test_select_column.py` and update `functions/utils.py::_select_column_names` testcase. PR #1152 @Zeroto521 +- [TST] Update `functions/utils.py::_select_column_names` testcase. PR #1152 @Zeroto521 ## [v0.23.1] - 2022-05-03