changes to reduce num of flake8 warning

Author: asmirnov69

pyjviz/code_block.py

@@ -1,6 +1,7 @@
 from . import code_block_rdf
 from . import wb_stack
 
+
 class CodeBlock(wb_stack.WithBlock):
     """
     CodeBlock (also has name alias CB) is diagram object representing code block defined via *with* statement.
@@ -9,14 +10,16 @@ class CodeBlock(wb_stack.WithBlock):
        .. python code is here ..
     
     ```
-    """
-    def __init__(self, label = None):
+    """ # noqa : 501
+
+    def __init__(self, label=None):
         super().__init__(label)
         self.back = code_block_rdf.CodeBlockRDF(self)
 
         self.back.dump_rdf()
 
     def on_exit__(self):
         self.back.flush_triples()
-        
+
+
 CB = CodeBlock

pyjviz/code_block_rdf.py

@@ -1,16 +1,26 @@
 from . import fstriplestore
 from . import rdf_utils
 
+
 class CodeBlockRDF(rdf_utils.RDFRep):
     def __init__(self, code_block):
-        self.set_rdf_rep(rdf_type = "CodeBlock")
+        self.set_rdf_rep(rdf_type="CodeBlock")
         self.front = code_block
-        
+
     def dump_rdf(self):
         ts = fstriplestore.triple_store
         ts.dump_triple(self.uri, "rdf:type", self.rdf_type_uri)
-        ts.dump_triple(self.uri, "rdf:label", f'"{self.front.label}"' if self.front.label else "rdf:nil")
-        parent_uri = self.front.parent_stack_entry.back.uri if self.front.parent_stack_entry else "rdf:nil"
+        if self.front.label:
+            l_uri = f'"{self.front.label}"'
+        else:
+            l_uri = "rdf:nil"
+
+        if self.front.parent_stack_entry:
+            parent_uri = self.front.parent_stack_entry.back.uri
+        else:
+            parent_uri = "rdf:nil"
+
+        ts.dump_triple(self.uri, "rdf:label", l_uri)
         ts.dump_triple(self.uri, "<part-of>", parent_uri)
 
     def flush_triples(self):

pyjviz/dia_objs.py

@@ -27,34 +27,36 @@ class TextRDF {
     + dump_rdf()
     }
     ```
-
-
-"""
+""" # noqa : 501
 from . import wb_stack
 from .dia_objs_rdf import TextRDF
 
+
 class DiagramObj:
     """
     base class of python objects which will have visible diagram representation.
     The diagram object has corresponding <b>back</b> object which class belongs to RDFRep.
     E.g. Text class will have back ref to TextRDF class object.
-    """
+    """ # noqa : 501
+
     def __init__(self):
         self.back = None
 
+
 class Text(DiagramObj):
     """
     Text class is to represent text box primitive for pyjviz diagram.
     """
-    def __init__(self, title, text, parent_obj = None):
-        if parent_obj:
-            if not isinstance(parent_obj, DiagramObj):
-                raise Exception(f"parent_obj must be instance of subclass of DiagramObj, {type(parent_obj)}")
-        else:
+    def __init__(self, title, text, parent_obj=None):
+        if not parent_obj:
             parent_obj = wb_stack.wb_stack.get_top()
 
-        self.back = TextRDF(self)
+        if not isinstance(parent_obj, DiagramObj):
+            msg = \
+                f"parent_obj is not subclass of DiagramObj, {type(parent_obj)}"
+            raise Exception(msg)
 
+        self.back = TextRDF(self)
         self.parent_obj = parent_obj
         self.title = title
         self.text = text

pyjviz/dia_objs_rdf.py

@@ -7,15 +7,15 @@
 
 class TextRDF(rdf_utils.RDFRep):
     def __init__(self, text_obj: dia_objs.Text):
-        self.set_rdf_rep(rdf_type = "Text")
+        self.set_rdf_rep(rdf_type="Text")
         self.front = text_obj
 
     def dump_rdf(self):
-        ts = fstriplestore.triple_store        
+        ts = fstriplestore.triple_store
         ts.dump_triple(self.uri, "rdf:type", self.rdf_type_uri)
         parent_obj = self.front.parent_obj
         parent_uri = parent_obj.back.uri if parent_obj else "rdf:nil"
         ts.dump_triple(self.uri, "<part-of>", parent_uri)
         ts.dump_triple(self.uri, "<title>", '"' + self.front.title + '"')
-        ts.dump_triple(self.uri, "<text>", '"' + fstriplestore.to_base64(self.front.text) + '"')
-        
+        text_b64 = '"' + fstriplestore.to_base64(self.front.text) + '"'
+        ts.dump_triple(self.uri, "<text>", text_b64)

pyjviz/fstriplestore.py

@@ -1,17 +1,21 @@
 import os
 import os.path
 import textwrap
-import io, base64
+import io
+import base64
 import rdflib
 
 base_uri = "https://github.com/pyjanitor-devs/pyjviz/rdflog.shacl.ttl#"
 
+
 def to_base64(s):
     return base64.b64encode(s.encode('ascii')).decode('ascii')
 
+
 def from_base64(s):
     return base64.b64decode(s).decode('ascii')
 
+
 class FSTripleOutput:
     def __init__(self, out_fd):
         global base_uri
@@ -45,8 +49,10 @@ def dump_prefixes__(self):
 
         <CC> rdf:type rdfs:Class .
         <CCObjStateLabel> rdf:type rdfs:Class .
-        <CCObjStateLabelDataFrame> rdf:type rdfs:Class; rdfs:subClassOf <CCObjStateLabel> .
-        <CCObjStateLabelSeries> rdf:type rdfs:Class; rdfs:subClassOf <CCObjStateLabel> .
+        <CCObjStateLabelDataFrame> rdf:type rdfs:Class .
+        <CCObjStateLabelDataFrame> rdfs:subClassOf <CCObjStateLabel> .
+        <CCObjStateLabelSeries> rdf:type rdfs:Class .
+        <CCObjStateLabelSeries> rdfs:subClassOf <CCObjStateLabel> .
         <CCGlance> rdf:type rdfs:class; rdfs:subClassOf <CC> .
         <CCBasicPlot> rdf:type rdfs:Class; rdfs:subClassOf <CC> .
         """
@@ -98,6 +104,5 @@ def dump_triple(self, s, p, o):
 
 
 def set_triple_store__(o):
-    #print("setting up triple_store:", o)
     global triple_store
     triple_store = o

pyjviz/method_call.py

@@ -1,20 +1,19 @@
-import ipdb
 import threading
 import pandas as pd
 import inspect
 
 from . import wb_stack
-from . import fstriplestore
 from . import obj_tracking
 from . import obj_utils
+from . import method_call_rdf
+from . import rdf_io
 
 from .nested_call import NestedCall
 
-from . import method_call_rdf
+# NB: should be better way to count method calls
+method_counter = 0
 
-from . import rdf_io
 
-method_counter = 0  # NB: should be better way to count method calls
 class MethodCall(wb_stack.WithBlock):
     def __init__(self, method_name):
         super().__init__(method_name)
@@ -23,27 +22,29 @@ def __init__(self, method_name):
         self.method_bound_args = None
 
         self.args_l = None
-        
+
     def add_args_l_entry__(self, arg_name, arg_obj):
-        if arg_name is None: arg_name = f"arg_{len(self.args_l)}"
-        
+        if arg_name is None:
+            arg_name = f"arg_{len(self.args_l)}"
+
         if type(arg_obj).__name__ == "NestedCall":
             self.args_l.append((arg_name, arg_obj))
-        elif isinstance(arg_obj, pd.DataFrame) or isinstance(arg_obj, pd.Series):
+        elif isinstance(arg_obj, pd.DataFrame) \
+                 or isinstance(arg_obj, pd.Series):
             arg_obj_id, found = obj_tracking.get_tracking_obj(arg_obj)
-            #print("arg id:", id(arg_obj), found)
+
             if found:
                 arg_obj_state = arg_obj_id.last_obj_state
             else:
                 arg_obj_state = obj_utils.ObjState(arg_obj, arg_obj_id)
-                    
+
             self.args_l.append((arg_name, arg_obj_state))
         else:
             self.args_l.append((arg_name, arg_obj))
-                
+
     def build_args_l__(self):
         self.args_l = []
-        for arg_name, arg_obj in self.method_bound_args.arguments.items():            
+        for arg_name, arg_obj in self.method_bound_args.arguments.items():
             arg_kind = self.method_signature.parameters.get(arg_name).kind
             if arg_kind == inspect.Parameter.VAR_KEYWORD:
                 for kwarg_name, kwarg_obj in arg_obj.items():
@@ -54,7 +55,7 @@ def build_args_l__(self):
                     self.add_args_l_entry__(None, p_arg_obj)
             else:
                 self.add_args_l_entry__(arg_name, arg_obj)
-        
+
     def handle_start_method_call(self, method_name, method_signature, method_args, method_kwargs):
         if method_name == "pin":
             arg0_obj = method_args[0]
@@ -64,47 +65,54 @@ def handle_start_method_call(self, method_name, method_signature, method_args, m
             else:
                 raise Exception("logical error: expected to have obj state created before")
             return method_args, method_kwargs
-            
+
         self.thread_id = threading.get_native_id()
 
         all_args = method_args
         self.method_signature = method_signature
         self.method_bound_args = self.method_signature.bind(*all_args, **method_kwargs)
         args_w_specified_values = self.method_bound_args.arguments.keys()
         # NB:
-        # according to python doc default values are evaluated and saved only once when function is defined
-        # apply_defaults method is to be used to put default values to method_bound_args.arguments
-        # decision to call or not to call apply_defaults could affect program execution since we could modify arguments
-        # of real method call which will happen after this method returns new args and kwargs.
+        # according to python doc default values are evaluated and saved only
+        # once when function is defined. apply_defaults method is to be used to
+        # put default values to `method_bound_args.arguments`. decision to call
+        # or not to call apply_defaults could affect program execution since we
+        # could modify arguments of real method call which will happen after this
+        # method returns new args and kwargs.
         # E.g. loop over all arguments will be affected
-        # since apply_defaults will add new entries which were skipped by method_signature.bind since they are omit and use default values
+        # since apply_defaults will add new entries which were skipped by
+        # method_signature.bind since they are omit and use default values
         #  --- >>>> commented out ---> self.method_bound_args.apply_defaults()
 
         # NB:
-        # loop over args_w_specified_values will skip the args where func value should be supplied and default func value is used.
-        # purpose of the loop is to replace such func arg values with equivalent obj of class NestedCall which suppose to collect
-        # call tracking information for visualization. so no such information will be collected for fund args where default value is used
+        # loop over args_w_specified_values will skip the args where func value
+        # should be supplied and default func value is used.
+        # purpose of the loop is to replace such func arg values with
+        # equivalent obj of class NestedCall which suppose to collect call
+        # tracking information for visualization. so no such information will
+        # be collected for fund args where default value is used
         for arg_name in args_w_specified_values:
             arg_value = self.method_bound_args.arguments.get(arg_name)
             arg_kind = method_signature.parameters.get(arg_name).kind
 
-            #print(method_name, arg_name, arg_kind)
             if arg_kind == inspect.Parameter.VAR_KEYWORD:
                 # case for lambda args of assign
                 updates_d = {}
                 for kwarg_name, kwarg_value in arg_value.items():
                     if inspect.isfunction(kwarg_value):
-                        # create empty nested call obj as placeholder for future results
+                        # create empty nested call obj
+                        # as placeholder for future results
                         new_kwarg_value = NestedCall(kwarg_name, kwarg_value)
                         updates_d[kwarg_name] = new_kwarg_value
                 self.method_bound_args.arguments[arg_name].update(updates_d)
 
         self.build_args_l__()
-        
+
         new_args = self.method_bound_args.args
         new_kwargs = self.method_bound_args.kwargs
-        
-        # NB: since apply_defaults is not called then no tracking of args with default values will take place
+
+        # NB: since apply_defaults is not called then no tracking of args
+        # with default values will take place
         self.back.dump_rdf_method_call_in()
 
         return new_args, new_kwargs
@@ -114,14 +122,16 @@ def handle_end_method_call(self, ret):
             return
 
         if ret is None:
-            raise Exception(f"method call of {self.method_name} returned None, can't use it chained method calls")
-        
+            msg = f"method call of {self.method_name} returned None,"
+            " can't use it chained method calls"
+            raise Exception(msg)
+
         ret_obj_id, found = obj_tracking.get_tracking_obj(ret)
         if found:
             ret_obj_id.last_version_num += 1
 
         # since we don't know was object state changed or not
         # we create new object state and set it as last obj state in obj id
         self.ret_obj_state = obj_utils.ObjState(ret, ret_obj_id)
-        
+
         self.back.dump_rdf_method_call_out()