Fix inference from nested unpacking of iterables (#1311)

Author: mbyrnepr2

ChangeLog

@@ -20,6 +20,10 @@ Release date: TBA
 * Rename ``ModuleSpec`` -> ``module_type`` constructor parameter to match attribute
   name and improve typing. Use ``type`` instead.
 
+* Fixed pylint ``not-callable`` false positive with nested-tuple assignment in a for-loop.
+
+  Refs PyCQA/pylint#5113
+
 * Add a bound to the inference tips cache.
 
   Closes #1150

astroid/protocols.py

@@ -240,6 +240,11 @@ def _resolve_looppart(parts, assign_path, context):
             itered = part.itered()
         except TypeError:
             continue
+        try:
+            if isinstance(itered[index], (nodes.Const, nodes.Name)):
+                itered = [part]
+        except IndexError:
+            pass
         for stmt in itered:
             index_node = nodes.Const(index)
             try:

tests/unittest_inference.py

@@ -798,6 +798,45 @@ def test_simple_for_genexpr(self) -> None:
             [i.value for i in test_utils.get_name_node(ast, "e", -1).infer()], [1, 3]
         )
 
+    def test_for_dict(self) -> None:
+        code = """
+            for a, b in {1: 2, 3: 4}.items():
+                print(a)
+                print(b)
+
+            for c, (d, e) in {1: (2, 3), 4: (5, 6)}.items():
+                print(c)
+                print(d)
+                print(e)
+
+            print([(f, g, h) for f, (g, h) in {1: (2, 3), 4: (5, 6)}.items()])
+        """
+        ast = parse(code, __name__)
+        self.assertEqual(
+            [i.value for i in test_utils.get_name_node(ast, "a", -1).infer()], [1, 3]
+        )
+        self.assertEqual(
+            [i.value for i in test_utils.get_name_node(ast, "b", -1).infer()], [2, 4]
+        )
+        self.assertEqual(
+            [i.value for i in test_utils.get_name_node(ast, "c", -1).infer()], [1, 4]
+        )
+        self.assertEqual(
+            [i.value for i in test_utils.get_name_node(ast, "d", -1).infer()], [2, 5]
+        )
+        self.assertEqual(
+            [i.value for i in test_utils.get_name_node(ast, "e", -1).infer()], [3, 6]
+        )
+        self.assertEqual(
+            [i.value for i in test_utils.get_name_node(ast, "f", -1).infer()], [1, 4]
+        )
+        self.assertEqual(
+            [i.value for i in test_utils.get_name_node(ast, "g", -1).infer()], [2, 5]
+        )
+        self.assertEqual(
+            [i.value for i in test_utils.get_name_node(ast, "h", -1).infer()], [3, 6]
+        )
+
     def test_builtin_help(self) -> None:
         code = """
             help()

tests/unittest_protocols.py

@@ -70,6 +70,48 @@ def test_assigned_stmts_simple_for(self) -> None:
         for2_assnode = next(assign_stmts[1].nodes_of_class(nodes.AssignName))
         self.assertRaises(InferenceError, list, for2_assnode.assigned_stmts())
 
+    def test_assigned_stmts_nested_for_tuple(self) -> None:
+        assign_stmts = extract_node(
+            """
+        for a, (b, c) in [(1, (2, 3))]:  #@
+          pass
+        """
+        )
+
+        assign_nodes = assign_stmts.nodes_of_class(nodes.AssignName)
+
+        for1_assnode = next(assign_nodes)
+        assigned = list(for1_assnode.assigned_stmts())
+        self.assertConstNodesEqual([1], assigned)
+
+        for2_assnode = next(assign_nodes)
+        assigned2 = list(for2_assnode.assigned_stmts())
+        self.assertConstNodesEqual([2], assigned2)
+
+    def test_assigned_stmts_nested_for_dict(self) -> None:
+        assign_stmts = extract_node(
+            """
+        for a, (b, c) in {1: ("a", str), 2: ("b", bytes)}.items():  #@
+            pass
+        """
+        )
+        assign_nodes = assign_stmts.nodes_of_class(nodes.AssignName)
+
+        # assigned: [1, 2]
+        for1_assnode = next(assign_nodes)
+        assigned = list(for1_assnode.assigned_stmts())
+        self.assertConstNodesEqual([1, 2], assigned)
+
+        # assigned2: ["a", "b"]
+        for2_assnode = next(assign_nodes)
+        assigned2 = list(for2_assnode.assigned_stmts())
+        self.assertConstNodesEqual(["a", "b"], assigned2)
+
+        # assigned3: [str, bytes]
+        for3_assnode = next(assign_nodes)
+        assigned3 = list(for3_assnode.assigned_stmts())
+        self.assertNameNodesEqual(["str", "bytes"], assigned3)
+
     def test_assigned_stmts_starred_for(self) -> None:
         assign_stmts = extract_node(
             """