Fix crash if a variable named "type" is subscripted in a generator expression (#1285)

Co-authored-by Marc Mueller <[email protected]>

Author: jacobtylerwalls

ChangeLog

@@ -20,6 +20,10 @@ Release date: TBA
 
 * Fix typing and update explanation for ``Arguments.args`` being ``None``.
 
+* Fix crash if a variable named ``type`` is subscripted in a generator expression.
+
+  Closes PyCQA/pylint#5461
+
 
 What's New in astroid 2.9.0?
 ============================

astroid/brain/brain_type.py

@@ -48,7 +48,7 @@ def infer_type_sub(node, context=None):
     :rtype: nodes.NodeNG
     """
     node_scope, _ = node.scope().lookup("type")
-    if node_scope.qname() != "builtins":
+    if not isinstance(node_scope, nodes.Module) or node_scope.qname() != "builtins":
         raise UseInferenceDefault()
     class_src = """
     class type:

tests/unittest_inference.py

@@ -4200,6 +4200,11 @@ class Test(Parent):
         assert isinstance(inferred, nodes.Const)
         assert inferred.value == 123
 
+    def test_uninferable_type_subscript(self) -> None:
+        node = extract_node("[type for type in [] if type['id']]")
+        with self.assertRaises(InferenceError):
+            _ = next(node.infer())
+
 
 class GetattrTest(unittest.TestCase):
     def test_yes_when_unknown(self) -> None: