Type _infer of Attribute, AssignAttr, Global and Subscript (#1657) (#1668)

Co-authored-by: Marc Mueller <[email protected]>

Author: DanielNoord

astroid/inference.py

@@ -233,6 +233,8 @@ def infer_name(
 
 
 # pylint: disable=no-value-for-parameter
+# The order of the decorators here is important
+# See https://github.com/PyCQA/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
 nodes.Name._infer = decorators.raise_if_nothing_inferred(  # type: ignore[assignment]
     decorators.path_wrapper(infer_name)
 )
@@ -277,8 +279,7 @@ def infer_import(
     **kwargs: Any,
 ) -> Generator[nodes.Module, None, None]:
     """infer an Import node: return the imported module/object"""
-    if not context:
-        raise InferenceError(node=self, context=context)
+    context = context or InferenceContext()
     name = context.lookupname
     if name is None:
         raise InferenceError(node=self, context=context)
@@ -304,8 +305,7 @@ def infer_import_from(
     **kwargs: Any,
 ) -> Generator[InferenceResult, None, None]:
     """infer a ImportFrom node: return the imported module/object"""
-    if not context:
-        raise InferenceError(node=self, context=context)
+    context = context or InferenceContext()
     name = context.lookupname
     if name is None:
         raise InferenceError(node=self, context=context)
@@ -334,18 +334,18 @@ def infer_import_from(
 nodes.ImportFrom._infer = infer_import_from  # type: ignore[assignment]
 
 
-def infer_attribute(self, context=None):
+def infer_attribute(
+    self: nodes.Attribute | nodes.AssignAttr,
+    context: InferenceContext | None = None,
+    **kwargs: Any,
+) -> Generator[InferenceResult, None, InferenceErrorInfo]:
     """infer an Attribute node by using getattr on the associated object"""
     for owner in self.expr.infer(context):
         if owner is util.Uninferable:
             yield owner
             continue
 
-        if not context:
-            context = InferenceContext()
-        else:
-            context = copy_context(context)
-
+        context = copy_context(context)
         old_boundnode = context.boundnode
         try:
             context.boundnode = owner
@@ -358,10 +358,12 @@ def infer_attribute(self, context=None):
             pass
         finally:
             context.boundnode = old_boundnode
-    return dict(node=self, context=context)
+    return InferenceErrorInfo(node=self, context=context)
 
 
-nodes.Attribute._infer = decorators.raise_if_nothing_inferred(
+# The order of the decorators here is important
+# See https://github.com/PyCQA/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
+nodes.Attribute._infer = decorators.raise_if_nothing_inferred(  # type: ignore[assignment]
     decorators.path_wrapper(infer_attribute)
 )
 # won't work with a path wrapper
@@ -370,8 +372,10 @@ def infer_attribute(self, context=None):
 
 @decorators.raise_if_nothing_inferred
 @decorators.path_wrapper
-def infer_global(self, context=None):
-    if context.lookupname is None:
+def infer_global(
+    self: nodes.Global, context: InferenceContext | None = None, **kwargs: Any
+) -> Generator[InferenceResult, None, None]:
+    if context is None or context.lookupname is None:
         raise InferenceError(node=self, context=context)
     try:
         return bases._infer_stmts(self.root().getattr(context.lookupname), context)
@@ -387,7 +391,9 @@ def infer_global(self, context=None):
 _SUBSCRIPT_SENTINEL = object()
 
 
-def infer_subscript(self, context=None):
+def infer_subscript(
+    self: nodes.Subscript, context: InferenceContext | None = None, **kwargs: Any
+) -> Generator[InferenceResult, None, InferenceErrorInfo | None]:
     """Inference for subscripts
 
     We're understanding if the index is a Const
@@ -439,10 +445,12 @@ def infer_subscript(self, context=None):
             found_one = True
 
     if found_one:
-        return dict(node=self, context=context)
+        return InferenceErrorInfo(node=self, context=context)
     return None
 
 
+# The order of the decorators here is important
+# See https://github.com/PyCQA/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
 nodes.Subscript._infer = decorators.raise_if_nothing_inferred(  # type: ignore[assignment]
     decorators.path_wrapper(infer_subscript)
 )
@@ -981,8 +989,7 @@ def _infer_augassign(
     self: nodes.AugAssign, context: InferenceContext | None = None
 ) -> Generator[InferenceResult | util.BadBinaryOperationMessage, None, None]:
     """Inference logic for augmented binary operations."""
-    if context is None:
-        context = InferenceContext()
+    context = context or InferenceContext()
 
     rhs_context = context.clone()
 

astroid/nodes/node_classes.py

@@ -32,6 +32,7 @@
 from astroid.nodes.node_ng import NodeNG
 from astroid.typing import (
     ConstFactoryResult,
+    InferenceErrorInfo,
     InferenceResult,
     SuccessfulInferenceResult,
 )
@@ -74,7 +75,7 @@ def _is_const(value):
 ]
 InferLHS = Callable[
     [_NodesT, Optional[InferenceContext]],
-    typing.Generator[InferenceResult, None, None],
+    typing.Generator[InferenceResult, None, Optional[InferenceErrorInfo]],
 ]
 InferUnaryOp = Callable[[_NodesT, str], ConstFactoryResult]
 
@@ -971,6 +972,8 @@ class AssignAttr(_base_nodes.ParentAssignNode):
     _astroid_fields = ("expr",)
     _other_fields = ("attrname",)
 
+    infer_lhs: ClassVar[InferLHS[AssignAttr]]
+
     @decorators.deprecate_default_argument_values(attrname="str")
     def __init__(
         self,
@@ -3850,6 +3853,8 @@ class Subscript(NodeNG):
     _astroid_fields = ("value", "slice")
     _other_fields = ("ctx",)
 
+    infer_lhs: ClassVar[InferLHS[Subscript]]
+
     def __init__(
         self,
         ctx: Context | None = None,