Replace platform import (#1459)

Author: cdce8p

astroid/const.py

@@ -1,5 +1,4 @@
 import enum
-import platform
 import sys
 
 PY36 = sys.version_info[:2] == (3, 6)
@@ -12,7 +11,8 @@
 
 WIN32 = sys.platform == "win32"
 
-IMPLEMENTATION_PYPY = platform.python_implementation() == "PyPy"
+IS_PYPY = sys.implementation.name == "pypy"
+IS_JYTHON = sys.implementation.name == "jython"
 
 
 class Context(enum.Enum):

astroid/modutils.py

@@ -46,13 +46,13 @@
 import importlib.util
 import itertools
 import os
-import platform
 import sys
 import sysconfig
 import types
 from pathlib import Path
 from typing import Dict, Set
 
+from astroid.const import IS_JYTHON, IS_PYPY
 from astroid.interpreter._import import spec, util
 
 if sys.platform.startswith("win"):
@@ -84,7 +84,7 @@
         except AttributeError:
             pass
 
-if platform.python_implementation() == "PyPy" and sys.version_info < (3, 8):
+if IS_PYPY and sys.version_info < (3, 8):
     # PyPy stores the stdlib in two places: sys.prefix/lib_pypy and sys.prefix/lib-python/3
     # sysconfig.get_path on PyPy returns the first, but without an underscore so we patch this manually.
     # Beginning with 3.8 the stdlib is only stored in: sys.prefix/pypy{py_version_short}
@@ -124,7 +124,6 @@ def _posix_path(path):
         STD_LIB_DIRS.add(_posix_path("lib64"))
 
 EXT_LIB_DIRS = {sysconfig.get_path("purelib"), sysconfig.get_path("platlib")}
-IS_JYTHON = platform.python_implementation() == "Jython"
 BUILTIN_MODULES = dict.fromkeys(sys.builtin_module_names, True)
 
 

astroid/nodes/scoped_nodes/scoped_nodes.py

@@ -57,7 +57,7 @@
 from astroid import bases
 from astroid import decorators as decorators_mod
 from astroid import mixins, util
-from astroid.const import IMPLEMENTATION_PYPY, PY38, PY38_PLUS, PY39_PLUS
+from astroid.const import IS_PYPY, PY38, PY38_PLUS, PY39_PLUS
 from astroid.context import (
     CallContext,
     InferenceContext,
@@ -2399,7 +2399,7 @@ def _newstyle_impl(self, context=None):
     @cached_property
     def fromlineno(self) -> Optional[int]:
         """The first line that this node appears on in the source code."""
-        if not PY38_PLUS or PY38 and IMPLEMENTATION_PYPY:
+        if not PY38_PLUS or PY38 and IS_PYPY:
             # For Python < 3.8 the lineno is the line number of the first decorator.
             # We want the class statement lineno. Similar to 'FunctionDef.fromlineno'
             lineno = self.lineno

astroid/rebuilder.py

@@ -54,7 +54,7 @@
 
 from astroid import nodes
 from astroid._ast import ParserModule, get_parser_module, parse_function_type_comment
-from astroid.const import IMPLEMENTATION_PYPY, PY36, PY38, PY38_PLUS, PY39_PLUS, Context
+from astroid.const import IS_PYPY, PY36, PY38, PY38_PLUS, PY39_PLUS, Context
 from astroid.manager import AstroidManager
 from astroid.nodes import NodeNG
 from astroid.nodes.utils import Position
@@ -224,7 +224,7 @@ def _fix_doc_node_position(self, node: NodesWithDocsType) -> None:
 
         lineno = node.lineno or 1  # lineno of modules is 0
         end_range: Optional[int] = node.doc_node.lineno
-        if IMPLEMENTATION_PYPY and not PY39_PLUS:
+        if IS_PYPY and not PY39_PLUS:
             end_range = None
         # pylint: disable-next=unsubscriptable-object
         data = "\n".join(self._data[lineno - 1 : end_range])
@@ -312,7 +312,7 @@ def visit_module(
             doc_node=self.visit(doc_ast_node, newnode),
         )
         self._fix_doc_node_position(newnode)
-        if IMPLEMENTATION_PYPY and PY38:
+        if IS_PYPY and PY38:
             self._reset_end_lineno(newnode)
         return newnode
 

tests/unittest_builder.py

@@ -43,7 +43,7 @@
 import pytest
 
 from astroid import Instance, builder, nodes, test_utils, util
-from astroid.const import IMPLEMENTATION_PYPY, PY38, PY38_PLUS, PY39_PLUS
+from astroid.const import IS_PYPY, PY38, PY38_PLUS, PY39_PLUS
 from astroid.exceptions import (
     AstroidBuildingError,
     AstroidSyntaxError,
@@ -79,7 +79,7 @@ def test_callfunc_lineno(self) -> None:
         self.assertEqual(name.tolineno, 4)
         strarg = callfunc.args[0]
         self.assertIsInstance(strarg, nodes.Const)
-        if IMPLEMENTATION_PYPY:
+        if IS_PYPY:
             self.assertEqual(strarg.fromlineno, 4)
             if not PY39_PLUS:
                 self.assertEqual(strarg.tolineno, 4)
@@ -187,7 +187,7 @@ class C:
 
         c = ast_module.body[2]
         assert isinstance(c, nodes.ClassDef)
-        if not PY38_PLUS or PY38 and IMPLEMENTATION_PYPY:
+        if not PY38_PLUS or PY38 and IS_PYPY:
             # Not perfect, but best we can do for Python 3.7 and PyPy 3.8
             # Can't detect closing bracket on new line.
             assert c.fromlineno == 12

tests/unittest_inference.py

@@ -44,7 +44,6 @@
 
 """Tests for the astroid inference capabilities"""
 
-import platform
 import textwrap
 import unittest
 from abc import ABCMeta
@@ -61,7 +60,7 @@
 from astroid.arguments import CallSite
 from astroid.bases import BoundMethod, Instance, UnboundMethod
 from astroid.builder import AstroidBuilder, extract_node, parse
-from astroid.const import PY38_PLUS, PY39_PLUS
+from astroid.const import IS_PYPY, PY38_PLUS, PY39_PLUS
 from astroid.context import InferenceContext
 from astroid.exceptions import (
     AstroidTypeError,
@@ -858,7 +857,7 @@ def test_builtin_open(self) -> None:
         self.assertIsInstance(inferred[0], nodes.FunctionDef)
         self.assertEqual(inferred[0].name, "open")
 
-    if platform.python_implementation() == "PyPy":
+    if IS_PYPY:
         test_builtin_open = unittest.expectedFailure(test_builtin_open)
 
     def test_callfunc_context_func(self) -> None:

tests/unittest_manager.py

@@ -24,7 +24,6 @@
 # For details: https://github.com/PyCQA/astroid/blob/main/LICENSE
 
 import os
-import platform
 import site
 import sys
 import time
@@ -36,13 +35,14 @@
 
 import astroid
 from astroid import manager, test_utils
+from astroid.const import IS_JYTHON
 from astroid.exceptions import AstroidBuildingError, AstroidImportError
 
 from . import resources
 
 
 def _get_file_from_object(obj) -> str:
-    if platform.python_implementation() == "Jython":
+    if IS_JYTHON:
         return obj.__file__.split("$py.class")[0] + ".py"
     return obj.__file__
 

tests/unittest_nodes.py

@@ -33,7 +33,6 @@
 """
 import copy
 import os
-import platform
 import sys
 import textwrap
 import unittest
@@ -290,12 +289,6 @@ def func(param: Tuple):
         ast = abuilder.string_build(code)
         self.assertEqual(ast.as_string().strip(), code.strip())
 
-    # This test is disabled on PyPy because we cannot get a release that has proper
-    # support for f-strings (we need 7.2 at least)
-    @pytest.mark.skipif(
-        platform.python_implementation() == "PyPy",
-        reason="Needs f-string support.",
-    )
     def test_f_strings(self):
         code = r'''
 a = f"{'a'}"

tests/unittest_nodes_lineno.py

@@ -4,11 +4,11 @@
 
 import astroid
 from astroid import builder, nodes
-from astroid.const import IMPLEMENTATION_PYPY, PY38, PY38_PLUS, PY39_PLUS, PY310_PLUS
+from astroid.const import IS_PYPY, PY38, PY38_PLUS, PY39_PLUS, PY310_PLUS
 
 
 @pytest.mark.skipif(
-    PY38_PLUS and not (PY38 and IMPLEMENTATION_PYPY),
+    PY38_PLUS and not (PY38 and IS_PYPY),
     reason="end_lineno and end_col_offset were added in PY38",
 )
 class TestEndLinenoNotSet:
@@ -37,7 +37,7 @@ def test_end_lineno_not_set() -> None:
 
 
 @pytest.mark.skipif(
-    not PY38_PLUS or PY38 and IMPLEMENTATION_PYPY,
+    not PY38_PLUS or PY38 and IS_PYPY,
     reason="end_lineno and end_col_offset were added in PY38",
 )
 class TestLinenoColOffset:

tests/unittest_raw_building.py

@@ -13,13 +13,13 @@
 # Licensed under the LGPL: https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html
 # For details: https://github.com/PyCQA/astroid/blob/main/LICENSE
 
-import platform
 import unittest
 
 import _io
 import pytest
 
 from astroid.builder import AstroidBuilder
+from astroid.const import IS_PYPY
 from astroid.raw_building import (
     attach_dummy_node,
     build_class,
@@ -85,7 +85,7 @@ def test_build_from_import(self) -> None:
         node = build_from_import("astroid", names)
         self.assertEqual(len(names), len(node.names))
 
-    @unittest.skipIf(platform.python_implementation() == "PyPy", "Only affects CPython")
+    @unittest.skipIf(IS_PYPY, "Only affects CPython")
     def test_io_is__io(self):
         # _io module calls itself io. This leads
         # to cyclic dependencies when astroid tries to resolve